Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #86346 #87609 #88684 #89319 #89444 upstream release 1.17 #89494

Conversation

@saad-ali
Copy link
Member

saad-ali commented Mar 25, 2020

What type of PR is this?
/kind bug
/sig storage
/priority important-soon

What this PR does / why we need it:
Cherry pick PRs #86346 #87609 #88684 #89319 #89444 from master to upstream release 1.17
/assign @liggitt
CC @SataQiu @andyzhangx @jsafrane @mboersma @gnufied

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

AzureFile and CephFS use new Mount library that prevents logging of sensitive mount options.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


SataQiu and others added 8 commits Dec 17, 2019
This fixes bug with xfs mount failing because of xfs_repair
being called. Fixes kubernetes/utils#141
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 25, 2020

@saad-ali: This cherry pick PR is for a release branch and has not yet been approved by the Patch Release Team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, please ping the kubernetes/patch-release-team in a comment, after it has been approved by the relevant OWNERS.
For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Mar 25, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: saad-ali
To complete the pull request process, please assign lavalamp
You can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Mar 26, 2020

/test pull-kubernetes-e2e-azure-file-windows

1 similar comment
@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Mar 26, 2020

/test pull-kubernetes-e2e-azure-file-windows

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Mar 26, 2020

/hold

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Mar 26, 2020

/hold cancel
hold for wrong PR...

Copy link
Member

andyzhangx left a comment

LGTM on windows and azure part

@andyzhangx

This comment has been minimized.

Copy link
Member

andyzhangx commented Mar 26, 2020

/lgtm

@saad-ali

This comment has been minimized.

Copy link
Member Author

saad-ali commented Mar 26, 2020

Thanks @andyzhangx

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Mar 31, 2020

This is a much larger change than I was expecting (and touches several areas we saw last-minute regressions/fixes in in the 1.18 dev cycle). @saad-ali, can you characterize the regression risks and test coverage for the areas this touched to help weigh the risk of this backport (xref https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md#what-kind-of-prs-are-good-for-cherry-picks)?

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Apr 4, 2020

@saad-ali: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.