ingress: Add Ingress to v1 API and update backend to defaultBackend #89778

cmluciano · 2020-04-02T16:18:53Z

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR adds Ingress to the networking v1 APIs. The planned rename of backend to defaultBackend is also implemented.

Which issue(s) this PR fixes:
xref:

Special notes for your reviewer:

Add v1 API
Renamed backend to defaultBackend

Does this PR introduce a user-facing change?:

`Ingress` and `IngressClass` resources have graduated to `networking.k8s.io/v1`. Ingress and IngressClass types in the `extensions/v1beta1` and `networking.k8s.io/v1beta1` API versions are deprecated and will no longer be served in 1.22+. Persisted objects can be accessed via the `networking.k8s.io/v1` API. Notable changes in v1 Ingress objects (v1beta1 field names are unchanged):
* `spec.backend` -> `spec.defaultBackend`
* `serviceName` -> `service.name`
* `servicePort` -> `service.port.name` (for string values)
* `servicePort` -> `service.port.number` (for numeric values)
* `pathType` no longer has a default value in v1; "Exact", "Prefix", or "ImplementationSpecific" must be specified
Other Ingress API updates:
* backends can now be resource or service backends
* `path` is no longer required to be a valid regular expression

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Ingress KEP

kubernetes/enhancements#1453

cmluciano · 2020-04-02T16:19:40Z

/cc @robscott @liggitt

fejta-bot · 2020-04-02T17:26:08Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

fedebongio · 2020-04-02T20:08:00Z

/assign @liggitt
/remove-sig api-machinery

cmluciano · 2020-04-02T21:04:50Z

/retest

cmluciano · 2020-04-03T16:46:49Z

/retest

cmluciano · 2020-04-07T16:53:15Z

/assign @robscott

robscott

Thanks for all the work on this! Will be great to get this in early in the release cycle.

pkg/apis/networking/types.go

pkg/apis/networking/v1beta1/BUILD

staging/src/k8s.io/api/networking/v1/types.go

api/api-rules/violation_exceptions.list

staging/src/k8s.io/api/networking/v1/types.go

api/api-rules/violation_exceptions.list

pkg/apis/networking/validation/validation.go

staging/src/k8s.io/api/networking/v1/types.go

kubernetes/kubernetes#91420 kubernetes/kubernetes#90672 kubernetes/kubernetes#90463 kubernetes/kubernetes#90671 kubernetes/kubernetes#89778

kubernetes/kubernetes#91420 kubernetes/kubernetes#90672 kubernetes/kubernetes#90671 kubernetes/kubernetes#89778 kubernetes/kubernetes#90463 can only be tacked later when the GRM vendors the 1.19 libraries and is capable of understanding autoscaling/v2beta2 (as it has some incompatible changes compared to autoscaling/v2beta1)

kubernetes/kubernetes#89778

In addition to `extensions/v1beta1`, `networking.k8s.io/v1beta1` was also deprecated in 1.19 and is also targeted for removal in 1.22. Deprecation PR: kubernetes/kubernetes#89778 Removal mention in deprecation guide: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122

k8s.io/v1beta1 → k8s.io/v1 https://stackoverflow.com/questions/64125048/get-error-unknown-field-servicename-in-io-k8s-api-networking-v1-ingressbacken kubernetes/kubernetes#89778

This commit implements the changes introduces in [1] and documented in [2] Mainly, this concerns the definiton of a `backend` and the necessity to declare a `pathType`[3]. I choose `ImplementationSpecific` here, as this was the default previously and passes the decision how the path should be matched to our `nignx-ingress`. [1] kubernetes/kubernetes#89778 [2] https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/ [3] https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#better-path-matching-with-path-types

k8s-ci-robot added kind/api-change size/XXL release-note cncf-cla: yes needs-sig needs-priority labels Apr 2, 2020

k8s-ci-robot requested review from caseydavenport and davidopp Apr 2, 2020

k8s-ci-robot added sig/api-machinery sig/apps sig/network and removed needs-sig labels Apr 2, 2020

cmluciano force-pushed the cml/ingressv1 branch from 99ae350 to 78d9926 Compare Apr 2, 2020

k8s-ci-robot assigned liggitt Apr 2, 2020

k8s-ci-robot removed the sig/api-machinery label Apr 2, 2020

k8s-ci-robot assigned robscott Apr 7, 2020

robscott reviewed Apr 7, 2020

View changes

liggitt added this to In progress in API Reviews Apr 7, 2020

liggitt added the api-review label Apr 7, 2020

liggitt reviewed Apr 7, 2020

View changes

api/api-rules/violation_exceptions.list Outdated Show resolved Hide resolved

liggitt reviewed Apr 7, 2020

View changes

staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved

liggitt reviewed Apr 7, 2020

View changes

liggitt moved this from In progress to Changes requested in API Reviews Apr 7, 2020

liggitt added this to the v1.19 milestone Apr 7, 2020

k8s-ci-robot merged commit 53f3699 into kubernetes:master Jun 17, 2020
19 checks passed

github-actions bot mentioned this pull request Jun 23, 2020

Week Ending June 21, 2020 p7t/actus#183

Open

Riaankl mentioned this pull request Jul 6, 2020

Endpoint promoted from Beta to Stable, showing up as untested in APISnoop cncf/apisnoop#363

Closed

2 tasks

rfranzke mentioned this pull request Aug 17, 2020

☂️-Issue for "Support for Kubernetes v1.19" gardener/gardener#2629

Closed

rfranzke added a commit to gardener/gardener that referenced this issue Aug 27, 2020

Update API versions for 1.19

db8e849

kubernetes/kubernetes#91420 kubernetes/kubernetes#90672 kubernetes/kubernetes#90463 kubernetes/kubernetes#90671 kubernetes/kubernetes#89778

rfranzke added a commit to gardener/gardener that referenced this issue Aug 28, 2020

Update API versions for 1.19

eaef065

kubernetes/kubernetes#91420 kubernetes/kubernetes#90672 kubernetes/kubernetes#90463 kubernetes/kubernetes#90671 kubernetes/kubernetes#89778

youssefazrak mentioned this pull request Oct 21, 2020

Helm: Adapt Hubble ingress template to the new Ingress API cilium/cilium#13682

Merged

tebeco mentioned this pull request Nov 1, 2020

Update ingress apiVersion now that it's not supposed to be beta anymore dotnet/tye#738

Closed

tebeco mentioned this pull request Nov 1, 2020

Update Ingress to v1 dotnet/tye#737

Open

VGerris mentioned this pull request Jan 18, 2021

path regex value not checked according to documentation kubernetes/ingress-nginx#6773

Closed

taishin mentioned this pull request Mar 4, 2021

[php] support ingress v1 chatwork/charts#221

Merged

1 task

taishin mentioned this pull request Mar 9, 2021

[PHP] add pathType param for ingress v1 chatwork/charts#225

Merged

1 task

taishin mentioned this pull request Mar 12, 2021

[akka] add patyType param for Ingress v1 chatwork/charts#226

Merged

1 task

tendant added a commit to tendant/simple-app that referenced this issue Jun 7, 2021

update serviceName, after upgrading to kubernetes 1.19

eca6a7d

kubernetes/kubernetes#89778

sschne mentioned this pull request Jun 27, 2021

remove omitempty tag from PathType #103003

Merged

valorl mentioned this pull request Jul 23, 2021

Add networking.k8s.io/v1beta1 ingress policy swade1987/deprek8ion#30

Merged

GusAntoniassi mentioned this pull request Jul 26, 2021

[Bug] Ingress.extensions "grafana-ingress" is invalid - pathType must be specified on Kubernetes 1.20+ grafana-operator/grafana-operator#487

Closed

hescmi mentioned this pull request Sep 29, 2021

update ingress templates logicmonitor/k8s-helm-charts#99

Open

atsikham mentioned this pull request Oct 12, 2021

Kubernetes v1.19 upgrade epiphany-platform/epiphany#2696

Merged

e11d added a commit to e11d/mastodon that referenced this issue Jan 2, 2022

Kubernetes v1.19 対応

e040914

k8s.io/v1beta1 → k8s.io/v1 https://stackoverflow.com/questions/64125048/get-error-unknown-field-servicename-in-io-k8s-api-networking-v1-ingressbacken kubernetes/kubernetes#89778

fredlahde mentioned this pull request Feb 25, 2022

Update Ingress Resource for k8s 21 worldiety/helm-charts#40

Merged

skrthomas mentioned this pull request Feb 28, 2022

[enterprise-4.6] Issue in file networking/routes/route-configuration.adoc openshift/openshift-docs#39935

Open

ingress: Add Ingress to v1 API and update backend to defaultBackend #89778

ingress: Add Ingress to v1 API and update backend to defaultBackend #89778

cmluciano commented Apr 2, 2020 •

edited by liggitt

cmluciano commented Apr 2, 2020 •

edited

fejta-bot commented Apr 2, 2020

fedebongio commented Apr 2, 2020

cmluciano commented Apr 2, 2020

cmluciano commented Apr 3, 2020

cmluciano commented Apr 7, 2020

robscott left a comment

ingress: Add Ingress to v1 API and update backend to defaultBackend #89778

ingress: Add Ingress to v1 API and update backend to defaultBackend #89778

Conversation

cmluciano commented Apr 2, 2020 • edited by liggitt

cmluciano commented Apr 2, 2020 • edited

fejta-bot commented Apr 2, 2020

fedebongio commented Apr 2, 2020

cmluciano commented Apr 2, 2020

cmluciano commented Apr 3, 2020

cmluciano commented Apr 7, 2020

robscott left a comment

cmluciano commented Apr 2, 2020 •

edited by liggitt

cmluciano commented Apr 2, 2020 •

edited