Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ingress: Add Ingress to v1 API and update backend to defaultBackend #89778

Merged
merged 1 commit into from Jun 17, 2020

Conversation

cmluciano
Copy link
Member

@cmluciano cmluciano commented Apr 2, 2020

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

What type of PR is this?
/kind api-change

What this PR does / why we need it:
This PR adds Ingress to the networking v1 APIs. The planned rename of backend to defaultBackend is also implemented.

Which issue(s) this PR fixes:
xref:

Special notes for your reviewer:

  • Add v1 API
  • Renamed backend to defaultBackend

Does this PR introduce a user-facing change?:

`Ingress` and `IngressClass` resources have graduated to `networking.k8s.io/v1`. Ingress and IngressClass types in the `extensions/v1beta1` and `networking.k8s.io/v1beta1` API versions are deprecated and will no longer be served in 1.22+. Persisted objects can be accessed via the `networking.k8s.io/v1` API. Notable changes in v1 Ingress objects (v1beta1 field names are unchanged):
* `spec.backend` -> `spec.defaultBackend`
* `serviceName` -> `service.name`
* `servicePort` -> `service.port.name` (for string values)
* `servicePort` -> `service.port.number` (for numeric values)
* `pathType` no longer has a default value in v1; "Exact", "Prefix", or "ImplementationSpecific" must be specified
Other Ingress API updates:
* backends can now be resource or service backends
* `path` is no longer required to be a valid regular expression

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Ingress KEP

kubernetes/enhancements#1453

@k8s-ci-robot k8s-ci-robot added kind/api-change size/XXL release-note cncf-cla: yes needs-sig needs-priority labels Apr 2, 2020
@cmluciano
Copy link
Member Author

@cmluciano cmluciano commented Apr 2, 2020

/cc @robscott @liggitt

@k8s-ci-robot k8s-ci-robot added sig/api-machinery sig/apps sig/network and removed needs-sig labels Apr 2, 2020
@fejta-bot
Copy link

@fejta-bot fejta-bot commented Apr 2, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@fedebongio
Copy link
Contributor

@fedebongio fedebongio commented Apr 2, 2020

/assign @liggitt
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery label Apr 2, 2020
@cmluciano
Copy link
Member Author

@cmluciano cmluciano commented Apr 2, 2020

/retest

1 similar comment
@cmluciano
Copy link
Member Author

@cmluciano cmluciano commented Apr 3, 2020

/retest

@cmluciano
Copy link
Member Author

@cmluciano cmluciano commented Apr 7, 2020

/assign @robscott

Copy link
Member

@robscott robscott left a comment

Thanks for all the work on this! Will be great to get this in early in the release cycle.

pkg/apis/networking/types.go Outdated Show resolved Hide resolved
pkg/apis/networking/types.go Outdated Show resolved Hide resolved
pkg/apis/networking/types.go Show resolved Hide resolved
pkg/apis/networking/v1beta1/BUILD Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
@liggitt liggitt added this to In progress in API Reviews Apr 7, 2020
@liggitt liggitt added the api-review label Apr 7, 2020
api/api-rules/violation_exceptions.list Outdated Show resolved Hide resolved
pkg/apis/networking/validation/validation.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/networking/v1/types.go Show resolved Hide resolved
@liggitt liggitt moved this from In progress to Changes requested in API Reviews Apr 7, 2020
@liggitt liggitt added this to the v1.19 milestone Apr 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 53f3699 into kubernetes:master Jun 17, 2020
19 checks passed
rfranzke added a commit to gardener/gardener that referenced this issue Aug 28, 2020
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this issue Aug 31, 2020
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this issue Aug 31, 2020
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this issue Sep 1, 2020
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
rfranzke added a commit to gardener/gardener that referenced this issue Sep 1, 2020
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
ezeeyahoo pushed a commit to ezeeyahoo/gardener that referenced this issue Feb 20, 2021
kubernetes/kubernetes#91420
kubernetes/kubernetes#90672
kubernetes/kubernetes#90671
kubernetes/kubernetes#89778

kubernetes/kubernetes#90463 can only be tacked
later when the GRM vendors the 1.19 libraries and is capable of
understanding autoscaling/v2beta2 (as it has some incompatible changes
compared to autoscaling/v2beta1)
valorl added a commit to valorl/deprek8ion that referenced this issue Jul 23, 2021
In addition to `extensions/v1beta1`, `networking.k8s.io/v1beta1` was
also deprecated in 1.19 and is also targeted for removal in 1.22.

Deprecation PR: kubernetes/kubernetes#89778
Removal mention in deprecation guide: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122
fredlahde added a commit to fredlahde/helm-charts that referenced this issue Feb 25, 2022
This commit implements the changes introduces in [1] and  documented in
[2]

Mainly, this concerns the definiton of a `backend` and the necessity to
declare a `pathType`[3].

I choose `ImplementationSpecific` here, as this was the default
previously and passes the decision how the path should be matched to our
`nignx-ingress`.

[1] kubernetes/kubernetes#89778
[2] https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/
[3] https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#better-path-matching-with-path-types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review approved area/apiserver area/code-generation area/dependency area/kubectl area/test cncf-cla: yes kind/api-change lgtm priority/important-soon release-note sig/api-machinery sig/apps sig/cli sig/network sig/testing size/XXL
Projects
API Reviews
API review completed, 1.19
Development

Successfully merging this pull request may close these issues.

None yet

7 participants