Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base-images: Use new debian-base:v2.1.0 and build new debian-iptables:v12.1.0 #90697

Merged
merged 5 commits into from May 6, 2020
Merged

base-images: Use new debian-base:v2.1.0 and build new debian-iptables:v12.1.0 #90697

merged 5 commits into from May 6, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented May 3, 2020 •
edited

What type of PR is this?
/kind cleanup
/area dependency security

What this PR does / why we need it:

  • Fixup GCB configs for debian-{base,iptables} images
  • Point debian-base image references to K8s Infra
  • Update dependents to use debian-base:v2.1.0
  • Build debian-iptables:v12.1.0 image

Which issue(s) this PR fixes:

Fixes #
Tracking issue: #58012

Special notes for your reviewer:

Continuation of #90665.

Does this PR introduce a user-facing change?:

- base-images: Use debian-base:v2.1.0

@justaugustus
build: Fixup GCB configs for debian-{base,iptables} images
0357843 
- Fix dir arguments
- Drop 'BASE_REGISTRY' env var from debian-iptables config

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 3, 2020
@k8s-ci-robot k8s-ci-robot added area/kubeadm area/kubectl area/kubelet area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 3, 2020
@justaugustus
Copy link
Member Author

/assign @dims @BenTheElder
cc: @kubernetes/release-engineering
/priority important-soon

I have a strong feeling a bunch of these will fail because I haven't tracked down all of the pause image references, but I'm getting this up in the meantime to get some signal.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 3, 2020
@justaugustus
releng: Point debian-base image references to K8s Infra
f828821 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 3, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2020
@justaugustus
Copy link
Member Author

/assign @thockin

Tim -- Do you have a little time for this debian-base image bump review? It's largely search/replace and should be quick.

@cblecker
Copy link
Member

cblecker commented May 4, 2020

/approve

dims
dims reviewed May 5, 2020
View reviewed changes
cluster/images/etcd-empty-dir-cleanup/Dockerfile
@@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM k8s.gcr.io/debian-base:v2.0.0
FROM us.gcr.io/k8s-artifacts-prod/build-image/debian-base:v2.1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump version number for this image

dims
dims reviewed May 5, 2020
View reviewed changes
cluster/images/etcd/Makefile
@@ -67,19 +67,19 @@ GOARM?=7
TEMP_DIR:=$(shell mktemp -d)

ifeq ($(ARCH),amd64)
BASEIMAGE?=k8s.gcr.io/debian-base:v2.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to bump version number for this image as well

@dims
Copy link
Member

dims commented May 5, 2020

/hold we either drop the changes to etcd images or bump their versions (and log follow up issues to build/push/update stuff)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020
@justaugustus
cluster/images/etcd: Bump etcd image tags for new debian-base
d95dcc6 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2020
@justaugustus justaugustus mentioned this pull request May 5, 2020
Closed
@justaugustus
Copy link
Member Author

We need to bump version number for this image as well

@dims -- Thanks for the catch! I've bumped both revision numbers and opened #90772 for the etcd image bumps.

cc: @jpbetz @wenjiaswe @jingyih
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2020
@dims
Copy link
Member

dims commented May 5, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 5, 2020 •
edited

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-conformance-kind-ipv6-parallel 20d5b64f314c0c2925c5f559fc53c2d55e25c138 link /test pull-kubernetes-conformance-kind-ipv6-parallel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@wenjiaswe
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit d8a513e into kubernetes:master May 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 6, 2020
This was referenced May 6, 2020
Merged
Merged
Merged
Merged
Merged
@rphillips rphillips mentioned this pull request May 10, 2020
Closed
14 tasks
@justaugustus justaugustus mentioned this pull request May 13, 2020
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@aojea aojea aojea left review comments

@hasheddan hasheddan hasheddan approved these changes

@bowei bowei Awaiting requested review from bowei

@brianpursley brianpursley Awaiting requested review from brianpursley

Assignees

@dims dims

@BenTheElder BenTheElder

@cblecker cblecker

@thockin thockin

@hasheddan hasheddan

@wenjiaswe wenjiaswe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/security area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@justaugustus @neolit123 @cblecker @dims @k8s-ci-robot @wenjiaswe @aojea @hasheddan @BenTheElder @thockin