Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip Pod Conditions from scheduling queue updates #91252

Merged
merged 1 commit into from May 19, 2020
Merged

Skip Pod Conditions from scheduling queue updates #91252

merged 1 commit into from May 19, 2020

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented May 19, 2020 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Skips updates in Pod Conditions so that there is no extra scheduling attempt when other controllers update Conditions while pod is binding.

Which issue(s) this PR fixes:

Fixes #91249

Does this PR introduce a user-facing change?:

Pod Conditions updates are skipped for re-scheduling attempts

@alculquicondor
Skip Pod Conditions from scheduling queue updates
da6fcfa 
Signed-off-by: Aldo Culquicondor <acondor@google.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 19, 2020
@alculquicondor
Copy link
Member Author

/sig scheduling
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 19, 2020
@k8s-ci-robot k8s-ci-robot requested review from hex108 and k82cn May 19, 2020 15:02
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
@alculquicondor
Copy link
Member Author

/retest

@ahg-g
Copy link
Member

ahg-g commented May 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@Huang-Wei
Copy link
Member

@alculquicondor it's worth a release note :)

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 19, 2020
@alculquicondor
Copy link
Member Author

Done

@k8s-ci-robot k8s-ci-robot merged commit 4b9b9ab into kubernetes:master May 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 19, 2020
This was referenced May 20, 2020
Closed
Merged
k8s-ci-robot added a commit that referenced this pull request May 30, 2020
@k8s-ci-robot
Merge pull request #91298 from alculquicondor/release-1.18-pod-updates
c79a8b2 
Cherry pick of #91099 #91252: Skip pod updates from scheduling queue updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Extra scheduling attempts when other controllers update Pod Conditions
5 participants
@alculquicondor @k8s-ci-robot @ahg-g @fejta-bot @Huang-Wei