From 4d8280acca782897dbf4439daa417f39af2466bd Mon Sep 17 00:00:00 2001 From: RainbowMango Date: Tue, 26 May 2020 20:11:42 +0800 Subject: [PATCH] rename metric scheduler_total_preemption_attempts to scheduler_preemption_attempts_total as counter metrics should have _total suffix. --- pkg/scheduler/metrics/metrics.go | 2 +- staging/src/k8s.io/component-base/metrics/testutil/promlint.go | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/pkg/scheduler/metrics/metrics.go b/pkg/scheduler/metrics/metrics.go index 36ec6248527a..f5bbd1648583 100644 --- a/pkg/scheduler/metrics/metrics.go +++ b/pkg/scheduler/metrics/metrics.go @@ -145,7 +145,7 @@ var ( PreemptionAttempts = metrics.NewCounter( &metrics.CounterOpts{ Subsystem: SchedulerSubsystem, - Name: "total_preemption_attempts", + Name: "preemption_attempts_total", Help: "Total preemption attempts in the cluster till now", StabilityLevel: metrics.ALPHA, }) diff --git a/staging/src/k8s.io/component-base/metrics/testutil/promlint.go b/staging/src/k8s.io/component-base/metrics/testutil/promlint.go index bc61008bb911..e5575b72cb26 100644 --- a/staging/src/k8s.io/component-base/metrics/testutil/promlint.go +++ b/staging/src/k8s.io/component-base/metrics/testutil/promlint.go @@ -53,9 +53,6 @@ var exceptionMetrics = []string{ // kube-proxy "kubernetes_build_info", - // kube-scheduler - "scheduler_total_preemption_attempts", - // kubelet-resource-v1alpha1 "container_cpu_usage_seconds_total", "node_cpu_usage_seconds_total",