Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving Kubelet kernel-memcg-notification to configuration file #91863

Merged
merged 1 commit into from Jun 25, 2020
Merged

Moving Kubelet kernel-memcg-notification to configuration file #91863

merged 1 commit into from Jun 25, 2020

Conversation

knabben
Copy link
Member

@knabben knabben commented Jun 6, 2020 •
edited

What type of PR is this?
/kind cleanup
/area kubelet
/area kubelet-api

What this PR does / why we need it:
Moving Kubelet --kernel-memcg-notification flags to Kubelet configuration file.

Which issue(s) this PR fixes:
Refs #86843

Special notes for your reviewer:

This flag was renamed from --experimental-kernel-memcg-notification to --kernel-memcg-notification

Does this PR introduce a user-facing change?:

The Kubelet's `--kernel-memcg-notification` option is now available via the Kubelet config file field kernelMemcgNotification

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/kubelet size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/kubelet-api cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 6, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @knabben. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 6, 2020
@knabben
Copy link
Member Author

knabben commented Jun 6, 2020

/assign @derekwaynecarr @dashpole

Should the cluster/gce/*.sh, be renamed in this PR?

https://cs.k8s.io/?q=experimental-kernel-memcg-notification&i=nope&files=&repos=

@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 6, 2020
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@matthyx
Copy link
Contributor

matthyx commented Jun 6, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2020
@knabben knabben force-pushed the kubelet-memcg-notification branch from 5de004e to d4ab61f Compare June 6, 2020 19:38
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 6, 2020
@knabben knabben force-pushed the kubelet-memcg-notification branch from d4ab61f to 4cb7c53 Compare June 7, 2020 13:50
@k8s-ci-robot k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 7, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2020
@dashpole
Copy link
Contributor

/approve

@mtaufen
Copy link
Contributor

mtaufen commented Jun 24, 2020

/assign @liggitt

liggitt
liggitt reviewed Jun 24, 2020
View reviewed changes
cmd/kubelet/app/options/options.go Outdated
@@ -543,4 +539,7 @@ func AddKubeletConfigFlags(mainfs *pflag.FlagSet, c *kubeletconfig.KubeletConfig
fs.StringSliceVar(&c.EnforceNodeAllocatable, "enforce-node-allocatable", c.EnforceNodeAllocatable, "A comma separated list of levels of node allocatable enforcement to be enforced by kubelet. Acceptable options are 'none', 'pods', 'system-reserved', and 'kube-reserved'. If the latter two options are specified, '--system-reserved-cgroup' and '--kube-reserved-cgroup' must also be set, respectively. If 'none' is specified, no additional options should be set. See https://kubernetes.io/docs/tasks/administer-cluster/reserve-compute-resources/ for more details.")
fs.StringVar(&c.SystemReservedCgroup, "system-reserved-cgroup", c.SystemReservedCgroup, "Absolute name of the top level cgroup that is used to manage non-kubernetes components for which compute resources were reserved via '--system-reserved' flag. Ex. '/system-reserved'. [default='']")
fs.StringVar(&c.KubeReservedCgroup, "kube-reserved-cgroup", c.KubeReservedCgroup, "Absolute name of the top level cgroup that is used to manage kubernetes components for which compute resources were reserved via '--kube-reserved' flag. Ex. '/kube-reserved'. [default='']")

// Graduated experimental flags, kept for backward compatibility
fs.BoolVar(&c.KernelMemcgNotification, "experimental-kernel-memcg-notification", c.KernelMemcgNotification, "Use kernelMemcgNotification configuration.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a target release for removal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liggitt PTAL

@liggitt
Copy link
Member

liggitt commented Jun 24, 2020

/approve
/hold one nit on setting a target removal release for the deprecated flag

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, knabben, liggitt, mtaufen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2020
@knabben knabben force-pushed the kubelet-memcg-notification branch from 105f3ed to 61aff55 Compare June 24, 2020 10:42
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2020
@knabben knabben force-pushed the kubelet-memcg-notification branch from 61aff55 to c39cf28 Compare June 24, 2020 10:44
@knabben
Copy link
Member Author

knabben commented Jun 24, 2020

/test pull-kubernetes-kubemark-e2e-gce-big

@liggitt
Copy link
Member

liggitt commented Jun 24, 2020

/lgtm

@liggitt
Copy link
Member

liggitt commented Jun 24, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 24, 2020
@knabben
Copy link
Member Author

knabben commented Jun 24, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@matthyx
Copy link
Contributor

matthyx commented Jun 25, 2020

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 4a91ecb into kubernetes:master Jun 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 25, 2020
@mtaufen mtaufen mentioned this pull request Jun 25, 2020
Closed
@serbrech
Copy link
Member

I know this is merged, but can we change the PR and the description to match the actual flag name?
it's says "memgc" but the flag is memcg.
that will help for searching at least. it got me confused :)

@knabben knabben changed the title Moving Kubelet kernel-memgc-notification to configuration file Moving Kubelet kernel-memcg-notification to configuration file Jun 30, 2020
@github-actions github-actions bot mentioned this pull request Jun 30, 2020
Open
@nayihz
Copy link
Contributor

nayihz commented Oct 1, 2021

hi @knabben, sorry to bother you. I'm trying to work on this issue and this is very similar to this pr. This is my commit.

I want to ask for help for building the binary. It keep failing when I tried to build kubelet binary by the command make WHAT=cmd/kubelet. After run the command make WHAT=cmd/kubelet, it automatically delete some code and add a warning comment in pkg/kubelet/apis/config/v1beta1/zz_generated.conversion.go and there is no change in staging/src/k8s.io/kubelet/config/v1beta1/types.go compared to your code.

This is my first time to modify the code related to api change. So could you give me some hints about this problem? Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtaufen mtaufen mtaufen left review comments

@liggitt liggitt liggitt left review comments

@alejandrox1 alejandrox1 alejandrox1 left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@mtaufen mtaufen

@liggitt liggitt

@dashpole dashpole

@derekwaynecarr derekwaynecarr

@matthyx matthyx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/kubelet-api area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet