New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kubeadm]:Bump CoreDNS to v1.7.0 #92651
[Kubeadm]:Bump CoreDNS to v1.7.0 #92651
Conversation
/cc @chrisohaver |
@@ -660,7 +660,9 @@ func TestCreateCoreDNSConfigMap(t *testing.T) { | |||
ttl 30 | |||
} | |||
prometheus :9153 | |||
forward . /etc/resolv.conf | |||
forward . /etc/resolv.conf { | |||
max_concurrent 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also mention this change in the release note? i don't have good statistical context on how breaking it is, but i'm going to assume it affects larger clusters with a lot of queries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The limit is per instance. The larger a cluster the more CoreDNS instances... So it should not change drastically at scale in theory. For comparison, kube-dns (via it's default dnsmasq behavior), had a limit of 150 concurrent queries. More details here. CoreDNS never had a limit before this, it would just OOM if too many queries came in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks for the details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding release notes: CoreDNS 1.7.0 does introduce some backward incompatible changes. Notably, it makes many Prometheus metrics name changes (to bring them in line with standard Prometheus metrics naming convention). They will be backward incompatible with existing reporting formulas that use the old metrics names. Less critically, 1.7.0 drops support for a couple of kubernetes plugin options which had already been deprecated and ignored by CoreDNS for several releases (i.e. now instead of ignoring them, CoreDNS will exit with an unknown directive error).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should briefly mention that in the k8s release note and even link to the coredns release notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I’ll update the release notes.
last time i've checked, feature freeze was on the 9th of July. |
/kind feature |
5584eb7
to
e18fb0b
Compare
@neolit123, I updated the release notes with "action required" for the metrics changes. |
or just link to the example github comment - e.g. "A workaround can be found here - LINK". |
7c076fd
to
626f53a
Compare
/lgtm i unblocked this PR, but hoping we will not get many user complains about the breaking changes. |
/milestone v1.19 |
/assign @liggitt |
cc @johnbelamaric for coredns breaking changes /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, neolit123, rajansandeep The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…rt for coredns up to v1.7.0
626f53a
to
2d574a6
Compare
/lgtm |
/retest |
1 similar comment
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Updates CoreDNS to v1.7.0. The default Corefile now includes the
max_concurrent
option, which sets the maximum number of concurrent upstream queries allowed by theforward
plugin.Also updates the migration library to 1.0.10 which supports coredns v1.7.0
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: