Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pod presets #94090

Merged
merged 4 commits into from Sep 14, 2020
Merged

remove pod presets #94090

merged 4 commits into from Sep 14, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 18, 2020

fixes #93900

This has lingered since 1.single-digit. In keeping with not allowing permabeta and following the example of sig-auth removing alpha features that aren't graduating, this PR removes PodPresets.

/priority important-soon
/kind api

The v1alpha1 PodPreset API and admission plugin has been removed with no built-in replacement. Admission webhooks can be used to modify pods on creation.

@kubernetes/sig-service-catalog
@kubernetes/api-approvers

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 18, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 18, 2020

@deads2k: The label(s) kind/api cannot be applied, because the repository doesn't have them

In response to this:

fixes #93900

This has lingered since 1.single-digit. In keeping with not allowing permabeta and following the example of sig-auth removing alpha features that aren't graduating, this PR removes PodPresets.

/priority important-soon
/kind api

PodPresets (alpha) are removed without a replacement.

@kubernetes/sig-service-catalog
@kubernetes/api-approvers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/apiserver area/kubectl area/provider/gcp Issues or PRs related to gcp provider area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 18, 2020
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 18, 2020
@k8s-ci-robot k8s-ci-robot requested review from mm4tt and SataQiu Aug 18, 2020
@fejta-bot
Copy link

fejta-bot commented Aug 18, 2020

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@dims
Copy link
Member

dims commented Aug 19, 2020

/cc

@k8s-ci-robot k8s-ci-robot requested a review from dims Aug 19, 2020
@liggitt liggitt self-assigned this Aug 19, 2020
@liggitt liggitt added this to the v1.20 milestone Aug 19, 2020
@dims
Copy link
Member

dims commented Sep 10, 2020

needs a rebase @deads2k

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2020
@deads2k
Copy link
Contributor Author

deads2k commented Sep 14, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Sep 14, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 54df1fd into kubernetes:master Sep 14, 2020
15 checks passed
alvaroaleman added a commit to alvaroaleman/test-infra that referenced this pull request Sep 15, 2020
lyarwood added a commit to lyarwood/kubevirt that referenced this pull request Jul 8, 2022
VirtualMachineInstancePresets are based on the PodPresets k8s resource
and API that injected data into pods at creation time. However this API
never graduated from alpha and was removed in 1.20 [1]. While useful
there are some issues with the implementation that have resulted in
alternative approaches such as  VirtualMachineInstanceTypes and
VirtualMachinePreferences being made available within KubeVirt.

As per the CRD versioning docs this change updates the generated CRD
definition of VirtualMachineInstancePreset marking the currently
available versions of v1 and v1alpha3 as deprecated.

[1] kubernetes/kubernetes#94090
[2] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#version-deprecation

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
lyarwood added a commit to lyarwood/kubevirt that referenced this pull request Jul 11, 2022
VirtualMachineInstancePresets are based on the PodPresets k8s resource
and API that injected data into pods at creation time. However this API
never graduated from alpha and was removed in 1.20 [1]. While useful
there are some issues with the implementation that have resulted in
alternative approaches such as  VirtualMachineInstanceTypes and
VirtualMachinePreferences being made available within KubeVirt.

As per the CRD versioning docs this change updates the generated CRD
definition of VirtualMachineInstancePreset marking the currently
available versions of v1 and v1alpha3 as deprecated.

[1] kubernetes/kubernetes#94090
[2] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#version-deprecation

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
lyarwood added a commit to lyarwood/kubevirt that referenced this pull request Jul 22, 2022
VirtualMachineInstancePresets are based on the PodPresets k8s resource
and API that injected data into pods at creation time. However this API
never graduated from alpha and was removed in 1.20 [1]. While useful
there are some issues with the implementation that have resulted in
alternative approaches such as  VirtualMachineInstanceTypes and
VirtualMachinePreferences being made available within KubeVirt.

As per the CRD versioning docs this change updates the generated CRD
definition of VirtualMachineInstancePreset marking the currently
available versions of v1 and v1alpha3 as deprecated.

[1] kubernetes/kubernetes#94090
[2] https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definition-versioning/#version-deprecation

Signed-off-by: Lee Yarwood <lyarwood@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/kubectl area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
API Reviews
API review completed, 1.20
Development

Successfully merging this pull request may close these issues.

Pod Presets still in alpha since v1.6, time to remove it?
6 participants