Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolerate NotFound errors when deleting snapshots #94653

Merged
merged 1 commit into from Sep 9, 2020
Merged

Tolerate NotFound errors when deleting snapshots #94653

merged 1 commit into from Sep 9, 2020

Conversation

jsafrane
Copy link
Member

@jsafrane jsafrane commented Sep 9, 2020

/kind bug
/kind failing-test

What this PR does / why we need it:
AWS EBS CSI driver tests fail occasionally with "volumesnapshots.snapshot.storage.k8s.io "snapshot-wmb7p" not found" error.

Make sure that deletion of already deleted snapshot object is evaluated as success and not as error.

NONE

cc @AndiLi99 @msau42

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 9, 2020
@jsafrane
Copy link
Member Author

jsafrane commented Sep 9, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 9, 2020
@msau42
Copy link
Member

msau42 commented Sep 9, 2020

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@msau42
Copy link
Member

msau42 commented Sep 9, 2020

/milestone v1.20

@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit b56d0ac into kubernetes:master Sep 9, 2020
@jsafrane jsafrane mentioned this pull request Sep 10, 2020
Merged
@jingxu97 jingxu97 mentioned this pull request Feb 3, 2021
Closed
This was referenced Feb 13, 2021
Closed
Closed
Closed
@jingxu97 jingxu97 mentioned this pull request Feb 19, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Feb 19, 2021
@k8s-ci-robot
Merge pull request #99220 from jingxu97/automated-cherry-pick-of-#87266-
f6ec471 
#93196-#94438-#94653-#95229-#95867-#96294-#96330-#96479-#96626-#96644-#96690-#96843-upstream-release-1.19

Automated cherry pick of 87266  93196 94438 94653 95229 95867 96294 96330 96479 96626 96644 96690 96843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@copejon copejon Awaiting requested review from copejon

@msau42 msau42 Awaiting requested review from msau42

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jsafrane @msau42 @k8s-ci-robot