Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable watchcache for events 1.18 #96117

Merged
merged 1 commit into from Nov 5, 2020
Merged

Disable watchcache for events 1.18 #96117

merged 1 commit into from Nov 5, 2020

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Nov 2, 2020

This is follow up from #96052 (the logic was changed in 1.19)
Ref #96049

Disable watchcache for events.k8.io/Event resource for compatibility with core/Event.

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 2, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2020
@liggitt
Copy link
Member

liggitt commented Nov 2, 2020

/lgtm
/approve
/retest
/sig scalability
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. triage/accepted Indicates an issue or PR is ready to be actively worked on. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 2, 2020
@wojtek-t
Copy link
Member Author

wojtek-t commented Nov 2, 2020

/retest

@kubernetes/release-managers - for cherrypick approval

@wojtek-t wojtek-t mentioned this pull request Nov 2, 2020
Merged
@mborsz mborsz mentioned this pull request Nov 4, 2020
Closed
cpanato
cpanato approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato cpanato added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 5, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 425ded3 into kubernetes:release-1.18 Nov 5, 2020
k8s-ci-robot added a commit that referenced this pull request Nov 5, 2020
@k8s-ci-robot
Merge pull request #96121 from wojtek-t/automated-cherry-pick-of-#961…
56fd0fe 
…17-upstream-release-1.17

Automated cherry pick of #96117 upstream release 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@mml mml Awaiting requested review from mml

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@liggitt liggitt

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wojtek-t @liggitt @k8s-ci-robot @cpanato