Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case of Age column in kubectl describe node #96963

Merged
merged 1 commit into from Mar 9, 2021
Merged

Fix case of Age column in kubectl describe node #96963

merged 1 commit into from Mar 9, 2021

Conversation

bl-ue
Copy link
Contributor

@bl-ue bl-ue commented Nov 30, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes casing of pod age column in the output of kubectl describe node

Which issue(s) this PR fixes:
Fixes #96919

Special notes for your reviewer:
See #63485

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup size/XS cncf-cla: yes do-not-merge/needs-sig needs-triage labels Nov 30, 2020
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Nov 30, 2020

Hi @bl-ue. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test needs-priority area/kubectl sig/cli and removed do-not-merge/needs-sig labels Nov 30, 2020
@bl-ue
Copy link
Contributor Author

@bl-ue bl-ue commented Nov 30, 2020

@derekwaynecarr @mengqiy This change needs to be made in the kubernetes/kubectl repository too—should I have made this PR over there or will it be ported?

@bl-ue
Copy link
Contributor Author

@bl-ue bl-ue commented Dec 1, 2020

/assign @soltysh

@bl-ue
Copy link
Contributor Author

@bl-ue bl-ue commented Dec 2, 2020

/remove-kind cleanup
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug and removed kind/cleanup labels Dec 2, 2020
@bl-ue
Copy link
Contributor Author

@bl-ue bl-ue commented Dec 4, 2020

/assign @fedebongio

@derekwaynecarr
Copy link
Member

@derekwaynecarr derekwaynecarr commented Jan 26, 2021

the change makes sense to me, will defer to sig-cli.

/ok-to-test
/unassign

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Jan 26, 2021
@derekwaynecarr derekwaynecarr removed their request for review Jan 26, 2021
@bl-ue
Copy link
Contributor Author

@bl-ue bl-ue commented Jan 26, 2021

/test pull-kubernetes-bazel-test

@dougsland
Copy link
Member

@dougsland dougsland commented Jan 29, 2021

looks trivial but make sense to be consistent with the other fields in the describe.
/triage accept
/lgtm

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jan 29, 2021

@dougsland: The label(s) triage/accept cannot be applied, because the repository doesn't have them

In response to this:

looks trivial but make sense to be consistent with the other fields in the describe.
/triage accept
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 29, 2021
@dougsland
Copy link
Member

@dougsland dougsland commented Jan 29, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted and removed needs-triage labels Jan 29, 2021
soltysh
soltysh approved these changes Mar 4, 2021
Copy link
Contributor

@soltysh soltysh left a comment

/approve

@k8s-ci-robot k8s-ci-robot added the approved label Mar 4, 2021
ohbus
ohbus approved these changes Mar 7, 2021
Copy link

@ohbus ohbus left a comment

/lgtm

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 7, 2021

@ohbus: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bl-ue, ohbus, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 9, 2021

/test pull-kubernetes-unit
the bot hangs for merge this PR

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Mar 9, 2021

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@bl-ue
Copy link
Contributor Author

@bl-ue bl-ue commented Mar 9, 2021

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit 97e2c84 into kubernetes:master Mar 9, 2021
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 9, 2021
@bl-ue bl-ue deleted the 96919-kubectl-describe-node-age-col branch Mar 9, 2021
@bl-ue
Copy link
Contributor Author

@bl-ue bl-ue commented Mar 9, 2021

Finally! 😅

@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubectl cncf-cla: yes kind/bug lgtm needs-priority ok-to-test release-note-none sig/cli size/XS triage/accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants