Change GetBootTime to work specificaly with FreeBSD #97270
Conversation
k8s-ci-robot
added
kind/cleanup
|
/test pull-kubernetes-e2e-gce-100-performance |
|
@rikatz Can you please update the Linux test to remove the freebsd build, and add a similar unit test for freebsd? |
|
@ehashman right now :) I've also renamed bootime_util_linux_test.go to boottime_util_linux_test.go to reflect the tested package/file (boottime_util_linux.go |
ehashman
left a comment
ehashman
left a comment
There was a problem hiding this comment.
/lgtm
seems fine to me, needs an approver to TAL
k8s-ci-robot
added
the
lgtm
|
Thanks! Do you want me to squash this into one commit only? |
|
These would be fine to squash since they're not logically separate, but generally k8s doesn't require squashing commits: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md |
Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@gmail.com>
rikatz
force-pushed
the
kubelet-bsd-1
branch
from
76a0f58 to
a1b66f1
Compare
k8s-ci-robot
removed
the
lgtm
|
Yup, I thought so (small commits right). Squashed here, will seek for an approver in slack! Thank you for the review! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @derekwaynecarr |
|
/test pull-kubernetes-node-e2e-podutil Triggering this to validate a non related prow job being worked with test-infra |
|
/pull-kubernetes-e2e-ubuntu-gce-network-policies |
|
/test pull-kubernetes-e2e-ubuntu-gce-network-policies |
|
/test pull-kubernetes-e2e-ubuntu-gce-network-policies |
|
/test pull-kubernetes-e2e-ubuntu-gce-network-policies This is the lucky attempt |
|
that's an experimental optional slow test, why is it running? hrm. would need a repo admin to override. |
|
No no! I’ve run that test here because me and @aojea were looking into
migrating the job! No worries with this one :) my fault here and this job is optional and I've trigged it manually :)
Em sex., 22 de jan. de 2021 às 19:49, Elana Hashman <
notifications@github.com> escreveu:
… that's an experimental optional slow test, why is it running? hrm. would
need a repo admin to override.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#97270 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWZQBJWEEQP36BBCASTRU3S3H6HFANCNFSM4UZXYVKQ>
.
|
|
/test pull-kubernetes-e2e-ubuntu-gce-network-policies Testing again @ehashman please disregard this test :) |
|
/triage accepted @rikatz the test failure will block this PR from merging as an FYI |
k8s-ci-robot
added
triage/accepted
Thanks :) I guessed, because it's optional (not Required) Prow would allow it to pass. Anyway I still have to wait for some approval and I'm following sig-net folks re-writing of this test :) Let me check the job history to see if it does pass now. Thank you very much! :) |
|
/test pull-kubernetes-e2e-ubuntu-gce-network-policies |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, mrunalp, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-kubernetes-conformance-kind-ga-only-parallel |
6 participants
Signed-off-by: Ricardo Pchevuzinske Katz ricardo.katz@gmail.com
/kind cleanup
What this PR does / why we need it: Kubernetes have some specific files to work in FreeBSD, but it doesn't actually compile in FreeBSD because the mode to get the uptime used in GetBootTime differs from Linux (and FreeBSD does not have a sysinfo syscall).
This PR uses the following syscall: https://www.freebsd.org/cgi/man.cgi?query=clock_gettime&apropos=0&sektion=0&manpath=FreeBSD+12.2-RELEASE&arch=default&format=html
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/sig node
/priority backlog