Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #94087: node sync at least once #97997

Closed
wants to merge 1 commit into from
Closed

Automated cherry pick of #94087: node sync at least once #97997

wants to merge 1 commit into from

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Jan 13, 2021 •
edited

Cherry pick of #94087 on release-1.18.

#94087: node sync at least once

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot
Copy link
Contributor

@ehashman: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please ping the kubernetes/release-managers team in a comment to request a cherry pick review.

(For details on the patch release process and schedule, see the Patch Releases page.)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 13, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

@ehashman: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ehashman
To complete the pull request process, please assign dashpole after the PR has been reviewed.
You can assign the PR to them by writing /assign @dashpole in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2021
@ehashman ehashman changed the title Automated cherry pick of #94087: WIP: node sync at least once Automated cherry pick of #94087: node sync at least once Jan 13, 2021
@ehashman
Copy link
Member Author

/release-note-none
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 13, 2021
@k8s-ci-robot
Copy link
Contributor

@ehashman: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce a2bab5f link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-kind a2bab5f link /test pull-kubernetes-e2e-kind
pull-kubernetes-node-e2e a2bab5f link /test pull-kubernetes-node-e2e
pull-kubernetes-integration a2bab5f link /test pull-kubernetes-integration
pull-kubernetes-e2e-gce-100-performance a2bab5f link /test pull-kubernetes-e2e-gce-100-performance
pull-kubernetes-bazel-build a2bab5f link /test pull-kubernetes-bazel-build
pull-kubernetes-bazel-test a2bab5f link /test pull-kubernetes-bazel-test
pull-kubernetes-typecheck a2bab5f link /test pull-kubernetes-typecheck
pull-kubernetes-verify a2bab5f link /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ehashman
Copy link
Member Author

I'm not sure we can backport this easily to 1.18, it looks like informers are not defined. I guess I'll close this and leave the 1.19 and 1.20 backports open.

@ehashman ehashman closed this Jan 13, 2021
@alculquicondor
Copy link
Member

@ehashman can you consider adapting the PR? 1.18 is still a supported version and the bug is present.

@ehashman
Copy link
Member Author

@alculquicondor while the original bug was marked critical-urgent, I'm not actually sure we actually see it that often in production. I don't have bandwidth to adapt the patch right now as I'm focused on some other bugs like #64715 and #97497, but I'd be happy to review if someone wanted to pick this up.

@alculquicondor
Copy link
Member

cc @yangxintian

@ehashman ehashman mentioned this pull request Jan 28, 2021
Closed
@cwdsuzhou
Copy link
Member

@ehashman @alculquicondor I have done this for branch release-1.18 since I think this an important bug fix.

I am not sure if we need do for 1.17 even 1.16!

@alculquicondor
Copy link
Member

cc @karan

@alculquicondor
Copy link
Member

@cwdsuzhou what's the PR?

Note that 1.17 and 1.16 are not supported versions anymore. Although I've seen the issue reproduce in 1.17.

@ehashman
Copy link
Member Author

ehashman commented Feb 8, 2021 •
edited

@cwdsuzhou none of those (1.16/1.17) are supported versions anymore so we would not be cherry-picking in upstream k8s.

@cwdsuzhou
Copy link
Member

@alculquicondor @ehashman #98848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees
No one assigned
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ehashman @k8s-ci-robot @alculquicondor @cwdsuzhou @derekwaynecarr