Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate file kubelet_node_status.go logs to structured logging and fix error description of reconcileHugePageResource log #98154

Merged
merged 1 commit into from Mar 12, 2021

Conversation

yangjunmyfm192085
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 commented Jan 19, 2021

Signed-off-by: JunYang yang.jun22@zte.com.cn

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
fix error description of log about reconcileHugePageResource function in pkg/kubelet/kubelet_node_status.go,
Structured Logging migration:
xref:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
part of kubernetes/enhancements#1602
As it is related to log, change the log here to structured log.
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none kind/cleanup size/XS cncf-cla: yes do-not-merge/needs-sig needs-triage labels Jan 19, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jan 19, 2021

Hi @yangjunmyfm192085. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test needs-priority labels Jan 19, 2021
@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and odinuge Jan 19, 2021
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node ok-to-test and removed do-not-merge/needs-sig needs-ok-to-test labels Jan 19, 2021
@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Jan 19, 2021
@bobbypage
Copy link
Member

@bobbypage bobbypage commented Jan 22, 2021

/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog and removed needs-priority labels Jan 22, 2021
@k8s-ci-robot k8s-ci-robot added size/S area/release-eng sig/release and removed size/XS labels Jan 23, 2021
@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Jan 23, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Jan 25, 2021

/triage accepted

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Feb 19, 2021

I have fixed all and the pr is ready for review @ehashman.

@ehashman
Copy link
Member

@ehashman ehashman commented Feb 19, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold label Feb 19, 2021
@ehashman ehashman moved this from Waiting on Author to Needs Reviewer in SIG Node PR Triage Feb 19, 2021
@serathius
Copy link
Contributor

@serathius serathius commented Feb 20, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Feb 20, 2021
@serathius
Copy link
Contributor

@serathius serathius commented Feb 20, 2021

/assign @dchen1107

@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Mar 2, 2021
@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 3, 2021

/test pull-kubernetes-unit

@ehashman
Copy link
Member

@ehashman ehashman commented Mar 4, 2021

/remove-priority backlog
/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon and removed priority/backlog labels Mar 4, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 11, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
@mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Mar 11, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 12, 2021

@yangjunmyfm192085: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-unit 28a2328 link /test pull-kubernetes-unit
pull-kubernetes-e2e-kind-ipv6 28a2328 link /test pull-kubernetes-e2e-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 12, 2021

/test pull-kubernetes-unit

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 12, 2021

/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot merged commit b5ba51b into kubernetes:master Mar 12, 2021
12 of 16 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 12, 2021
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet area/release-eng cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/node sig/release size/M triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

9 participants