Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable goaway testcases #98809

Merged

Conversation

answer1991
Copy link
Contributor

@answer1991 answer1991 commented Feb 5, 2021

What type of PR is this?

/kind flake

What this PR does / why we need it:

After we upgraded golang.org/x/net to latest version, goaway testcases will not flake.

Which issue(s) this PR fixes:

Fixes #94532
Fixes #94622

Special notes for your reviewer:

Apiserver's clients in k/k repo use golang.org/x/net/http2 to config http2 transports instead of use golang SDK h2_bundle. A new version of golang.org/x/net(with golang/net@ff519b6) will fix HTTP2 un-expected error when received GOAWAY frame.

For other clients which use default http2 configuration in golang SDK, golang 1.15.8 or 1.16+ required to avoid HTTP2 un-expected error when received GOAWAY frame.

Does this PR introduce a user-facing change?:

If kube-apiserver enabled goaway feature, clients required golang 1.15.8 or 1.16+ version to avoid un-expected data race issue.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note kind/flake size/XS cncf-cla: yes do-not-merge/needs-sig needs-triage needs-priority area/apiserver sig/api-machinery and removed do-not-merge/needs-sig labels Feb 5, 2021
@answer1991
Copy link
Contributor Author

@answer1991 answer1991 commented Feb 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and sttts Feb 5, 2021
@answer1991
Copy link
Contributor Author

@answer1991 answer1991 commented Feb 5, 2021

cc @liggitt @lavalamp @deads2k

@answer1991 answer1991 changed the title enable goaway testcases which will not flake any more with new golang.org/x/net version enable goaway testcases Feb 7, 2021
@answer1991
Copy link
Contributor Author

@answer1991 answer1991 commented Feb 8, 2021

/test pull-kubernetes-verify-govet-levee

@jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Feb 9, 2021

/assign @caesarxuchao
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted and removed needs-triage labels Feb 9, 2021
Copy link
Member

@caesarxuchao caesarxuchao left a comment

Thanks for looking into this flake!

@@ -438,10 +436,8 @@ func TestGOAWAYHTTP1Requests(t *testing.T) {
}

// TestGOAWAYConcurrency tests GOAWAY frame will not affect concurrency requests in a single http client instance.
// Known issues in history: https://github.com/kubernetes/kubernetes/issues/91131.
// Known issues in history: https://github.com/kubernetes/kubernetes/issues/91131, https://github.com/golang/go/issues/41234.
Copy link
Member

@caesarxuchao caesarxuchao Feb 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the flake is fixed, we don't need to record history in the comment anymore. Can you remove this line?

Copy link
Contributor Author

@answer1991 answer1991 Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done, thanks

@answer1991 answer1991 force-pushed the feature/enable-goaway-ut branch from 069e142 to f1b23fe Compare Feb 24, 2021
@answer1991
Copy link
Contributor Author

@answer1991 answer1991 commented Feb 24, 2021

/test pull-kubernetes-e2e-kind

failed e2e job:

Kubernetes e2e suite: [k8s.io] Probing container should not be ready until startupProbe succeeds
Kubernetes e2e suite: [k8s.io] [sig-node] RuntimeClass should run a Pod requesting a RuntimeClass with scheduling without taints

@answer1991
Copy link
Contributor Author

@answer1991 answer1991 commented Feb 24, 2021

e2e failed again with different cases:

Kubernetes e2e suite: [sig-apps] Deployment iterative rollouts should eventually progress 
Kubernetes e2e suite: [sig-network] Proxy version v1 A set of valid responses are returned for both pod and service ProxyWithPath [Conformance] 

/test pull-kubernetes-e2e-kind

@answer1991
Copy link
Contributor Author

@answer1991 answer1991 commented Mar 7, 2021

@caesarxuchao

Could you please take another look?

@caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented Mar 8, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 8, 2021
@caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented Mar 8, 2021

/assign @deads2k for approval. Thanks.

@lavalamp
Copy link
Member

@lavalamp lavalamp commented Mar 9, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: answer1991, caesarxuchao, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 9, 2021
@chymy
Copy link
Contributor

@chymy chymy commented Mar 9, 2021

/retest

@chymy
Copy link
Contributor

@chymy chymy commented Mar 9, 2021

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit a27a6e7 into kubernetes:master Mar 9, 2021
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 9, 2021
@answer1991
Copy link
Contributor Author

@answer1991 answer1991 commented Mar 15, 2021

Looks like #94532 will not flake any more. However, #94622 still has some problem, and I'm working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apiserver cncf-cla: yes kind/flake lgtm needs-priority ok-to-test release-note sig/api-machinery size/XS triage/accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants