Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured Logging migration: modify volume and container part logs o… #98850

Merged
merged 1 commit into from Mar 17, 2021

Conversation

yangjunmyfm192085
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 commented Feb 7, 2021

…f kubelet.

Signed-off-by: JunYang yang.jun22@zte.com.cn

What type of PR is this?
/kind feature

What this PR does / why we need it:
Structured Logging migration: modify volume and container part logs of kubelet.
xref:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
part of kubernetes/enhancements#1602
As it is related to log, change the log here to structured log.
Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none kind/feature size/L cncf-cla: yes do-not-merge/needs-sig needs-triage labels Feb 7, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 7, 2021

Hi @yangjunmyfm192085. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority needs-ok-to-test area/kubelet sig/node and removed do-not-merge/needs-sig labels Feb 7, 2021
@k8s-ci-robot k8s-ci-robot requested review from msau42 and yujuhong Feb 7, 2021
@matthyx
Copy link
Contributor

@matthyx matthyx commented Feb 8, 2021

/cc @serathius
/cc @matthyx

@k8s-ci-robot k8s-ci-robot requested review from matthyx and serathius Feb 8, 2021
pkg/kubelet/kubelet_volumes.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet_volumes.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet_volumes.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet_volumes.go Outdated Show resolved Hide resolved
pkg/kubelet/pod_workers.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/container/container_gc.go Outdated Show resolved Hide resolved
pkg/kubelet/container/helpers.go Outdated Show resolved Hide resolved
pkg/kubelet/container/helpers.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Outdated Show resolved Hide resolved
pkg/kubelet/runonce.go Show resolved Hide resolved
@mrunalp mrunalp moved this from Needs Approver to Waiting on Author in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 16, 2021
@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 16, 2021

I have fixed all @mrunalp.

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 16, 2021

/test pull-kubernetes-e2e-kind

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 16, 2021

/test pull-kubernetes-conformance-image-test

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 17, 2021

/test pull-kubernetes-e2e-gce-csi-serial

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 17, 2021

/test pull-kubernetes-conformance-image-test

pkg/kubelet/volumemanager/cache/actual_state_of_world.go Outdated Show resolved Hide resolved
@@ -142,7 +142,7 @@ func (kl *Kubelet) runPod(pod *v1.Pod, retryDelay time.Duration) error {
return fmt.Errorf("timeout error: pod %q containers not running after %d retries", format.Pod(pod), runOnceMaxRetries)
}
// TODO(proppy): health checking would be better than waiting + checking the state at the next iteration.
klog.Infof("pod %q containers synced, waiting for %v", format.Pod(pod), delay)
klog.InfoS("Pod's containers synced, waiting", "pod", klog.KObj(pod), "waitingTime", delay)
Copy link
Member

@ehashman ehashman Mar 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update waitingTime to duration

…f kubelet.

Signed-off-by: JunYang <yang.jun22@zte.com.cn>
@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 17, 2021

I have fixed them @ehashman

Copy link
Member

@ehashman ehashman left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 17, 2021
@ehashman ehashman moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Mar 17, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 17, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 17, 2021

@yangjunmyfm192085: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-conformance-image-test 3ec28f640bfb98267a5ad44d0023cf02af67ec8e link /test pull-kubernetes-conformance-image-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 17, 2021

/retest
Need approval

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit b5c6434 into kubernetes:master Mar 17, 2021
16 of 17 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 17, 2021
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 17, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/node size/L triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

10 participants