Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structured Logging migration: modify cri part logs of kubelet. #99006

Merged
merged 1 commit into from Mar 17, 2021

Conversation

yangjunmyfm192085
Copy link
Contributor

@yangjunmyfm192085 yangjunmyfm192085 commented Feb 11, 2021

Signed-off-by: JunYang yang.jun22@zte.com.cn

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Structured Logging migration: modify cri part logs of kubelet.
xref:
https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

part of kubernetes/enhancements#1602
As it is related to log, change the log here to structured log.

Does this PR introduce a user-facing change?

Migrate `pkg/kubelet/(cri)` to structured logging

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[Log migrate] 

@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup size/L cncf-cla: yes do-not-merge/needs-sig needs-triage needs-priority needs-ok-to-test labels Feb 11, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 11, 2021

Hi @yangjunmyfm192085. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node and removed do-not-merge/needs-sig labels Feb 11, 2021
@kikisdeliveryservice kikisdeliveryservice added the priority/important-soon label Feb 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-priority label Feb 11, 2021
@kikisdeliveryservice kikisdeliveryservice added the triage/accepted label Feb 11, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-triage label Feb 11, 2021
@kikisdeliveryservice
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice commented Feb 11, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Feb 11, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Triage to Needs Reviewer in SIG Node PR Triage Feb 11, 2021
@kikisdeliveryservice
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice commented Feb 11, 2021

related enhancement issue: kubernetes/enhancements#1602
related node issue: #98976

pkg/kubelet/cri/remote/remote_image.go Outdated Show resolved Hide resolved
pkg/kubelet/cri/remote/remote_image.go Outdated Show resolved Hide resolved
@ehashman ehashman moved this from Needs Reviewer to Waiting on Author in SIG Node PR Triage Feb 11, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Feb 11, 2021

/hold

#98589 migrates the same files and was submitted first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold label Feb 11, 2021
@yangjunmyfm192085 yangjunmyfm192085 force-pushed the run-test17 branch 2 times, most recently from 7c36ffb to d66ed03 Compare Feb 12, 2021
@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 4, 2021

/test pull-kubernetes-node-e2e

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 4, 2021

@ehashman I have completed all modifications,Could you help me take a look? thanks very much.

Copy link
Member

@ehashman ehashman left a comment

This LGTM other than my one comment, which I'm not sure should be blocking.

/lgtm

@ehashman ehashman moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 8, 2021
@ehashman ehashman moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 8, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 9, 2021
Signed-off-by: JunYang <yang.jun22@zte.com.cn>
Copy link
Member

@ehashman ehashman left a comment

re-
/lgtm

@mrunalp is this good?

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 9, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 11, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
@mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Mar 16, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 16, 2021
@ehashman ehashman moved this from Needs Approver to Done in Structured Logging Migration for Kubelet, 1.21 Mar 16, 2021
@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 16, 2021

/test pull-kubernetes-unit

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 16, 2021

/test pull-kubernetes-e2e-kind

2 similar comments
@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 16, 2021

/test pull-kubernetes-e2e-kind

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 17, 2021

/test pull-kubernetes-e2e-kind

@yangjunmyfm192085
Copy link
Contributor Author

@yangjunmyfm192085 yangjunmyfm192085 commented Mar 17, 2021

pull-kubernetes-e2e-kind

@pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 17, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit c5680da into kubernetes:master Mar 17, 2021
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note sig/node size/M triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

7 participants