Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote PodDisruptionBudget to policy/v1 #99290

Merged
merged 3 commits into from Mar 9, 2021

Conversation

mortent
Copy link
Member

@mortent mortent commented Feb 22, 2021

What type of PR is this?

/kind api-change
/kind feature

What this PR does / why we need it:

This promotes PodDisruptionBudget resource to policy/v1 based on kubernetes/enhancements#85 and detailed description in https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/85-Graduate-PDB-to-Stable

Which issue(s) this PR fixes:

Fixes #95083

Special notes for your reviewer:

This replaces an older PR at #81571.

Does this PR introduce a user-facing change?

The PodDisruptionBudget API has been promoted to policy/v1 with no schema changes. The only functional change is that an empty selector (`{}`) written to a policy/v1 PodDisruptionBudget now selects all pods in the namespace. The behavior of the policy/v1beta1 API remains unchanged. The policy/v1beta1 PodDisruptionBudget API is deprecated and will no longer be served in 1.25+.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/85-Graduate-PDB-to-Stable

@k8s-ci-robot k8s-ci-robot added release-note kind/api-change kind/feature size/XXL cncf-cla: yes do-not-merge/needs-sig needs-triage needs-priority labels Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubectl area/test sig/api-machinery sig/auth sig/cli sig/testing and removed do-not-merge/needs-sig labels Feb 22, 2021
@fejta-bot
Copy link

@fejta-bot fejta-bot commented Feb 22, 2021

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

Copy link
Contributor

@soltysh soltysh left a comment

I left you some initial comments, you're also missing necessary changes to pkg/api/testing/defaulting_test.go which you can see from unit-test failure from that package.

pkg/apis/policy/install/install.go Show resolved Hide resolved
pkg/features/kube_features.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/policy/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/policy/v1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/policy/v1beta1/types.go Outdated Show resolved Hide resolved
@mortent mortent force-pushed the PromotePDBsToGA branch 2 times, most recently from 2949f71 to bf8cad0 Compare Feb 23, 2021
@fedebongio
Copy link
Contributor

@fedebongio fedebongio commented Feb 23, 2021

/cc @wojtek-t
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot requested a review from wojtek-t Feb 23, 2021
@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery label Feb 23, 2021
staging/src/k8s.io/api/policy/v1beta1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/policy/v1beta1/types.go Outdated Show resolved Hide resolved
staging/src/k8s.io/api/policy/v1/types.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery label Feb 24, 2021
@mortent
Copy link
Member Author

@mortent mortent commented Feb 24, 2021

/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot added the needs-rebase label Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

@mortent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

3 similar comments
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

@mortent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

@mortent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

@mortent: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 9, 2021
@liggitt
Copy link
Member

@liggitt liggitt commented Mar 9, 2021

rebased with no conflicts
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm and removed needs-rebase labels Mar 9, 2021
@liggitt liggitt added the api-review label Mar 9, 2021
@liggitt
Copy link
Member

@liggitt liggitt commented Mar 9, 2021

/retest

@liggitt
Copy link
Member

@liggitt liggitt commented Mar 9, 2021

flakes were #99911 and #94564

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

@mortent: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-integration 66e7227 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mortent
Copy link
Member Author

@mortent mortent commented Mar 9, 2021

/test pull-kubernetes-integration

@liggitt
Copy link
Member

@liggitt liggitt commented Mar 9, 2021

integration flake is #98116 (comment)

@k8s-ci-robot k8s-ci-robot merged commit 046ad61 into kubernetes:master Mar 9, 2021
14 of 16 checks passed
@liggitt liggitt moved this from GA cleanup to Complete in PodDisruptionBudget Mar 15, 2021
@wilsonehusin
Copy link
Member

@wilsonehusin wilsonehusin commented Mar 29, 2021

hey folks, 1.21 Release Notes team here -- want to check in and disambiguate this line:

The only functional change is that an empty selector ({}) written to a policy/v1 PodDisruptionBudget now selects all pods in the namespace.

does this behavior warrant this note to be in ACTION REQUIRED / Urgent Upgrade Notes? I'm not too familiar with how PodDisruptionBudget works when given empty selector, and if this potentially creates side effect to end users on v1beta1 -> v1, then we might want to surface this note 😄

cc @mortent @liggitt

@liggitt
Copy link
Member

@liggitt liggitt commented Mar 29, 2021

No, there are no side effects to existing v1beta1 consumers that require action prior to upgrade to 1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-review approved area/apiserver area/cloudprovider area/dependency area/e2e-test-framework area/kubectl area/test cncf-cla: yes kind/api-change kind/feature lgtm priority/important-soon release-note sig/api-machinery sig/apps sig/auth sig/autoscaling sig/cli sig/cloud-provider sig/cluster-lifecycle sig/instrumentation sig/scheduling sig/testing size/XXL triage/accepted
Projects
API Reviews
API review completed, 1.21
Development

Successfully merging this pull request may close these issues.

10 participants