Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg/kubelet/cm/cpumanager/state to structured logging #99563

Conversation

jmguzik
Copy link
Contributor

@jmguzik jmguzik commented Feb 28, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate pkg/kubelet/cm/cpumanager/state to structured logging

Which issue(s) this PR fixes:

Part of #98976

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1602-structured-logging

/sig node instrumentation
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup size/S sig/node sig/instrumentation labels Feb 28, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 28, 2021

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added priority/important-soon cncf-cla: no needs-triage labels Feb 28, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 28, 2021

Welcome @jmguzik!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Feb 28, 2021

Hi @jmguzik. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test area/kubelet labels Feb 28, 2021
@k8s-ci-robot k8s-ci-robot requested review from klueska and vishh Feb 28, 2021
@jmguzik jmguzik force-pushed the migrate-cm-cpumanager-state-structured-logging branch from 91fd0a7 to 7dc1684 Compare Feb 28, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes and removed cncf-cla: no labels Feb 28, 2021
@jmguzik
Copy link
Contributor Author

@jmguzik jmguzik commented Feb 28, 2021

/cc @serathius

@k8s-ci-robot k8s-ci-robot requested a review from serathius Feb 28, 2021
@jmguzik jmguzik force-pushed the migrate-cm-cpumanager-state-structured-logging branch from 7dc1684 to f946ca2 Compare Mar 2, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 2, 2021
Copy link
Member

@ehashman ehashman left a comment

/ok-to-test
/triage accepted

/cc @klueska
I'm suggesting we remove the non-standard log prefix [cpumanager], klog should provide the file that was logged from as context.

pkg/kubelet/cm/cpumanager/state/state_checkpoint.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/state/state_checkpoint.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/state/state_mem.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/state/state_mem.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/state/state_mem.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/state/state_mem.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/state/state_mem.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/cpumanager/state/state_mem.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test triage/accepted and removed needs-ok-to-test needs-triage labels Mar 2, 2021
@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 2, 2021
Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
@jmguzik jmguzik force-pushed the migrate-cm-cpumanager-state-structured-logging branch from f946ca2 to 85d69cd Compare Mar 3, 2021
@jmguzik jmguzik requested review from ehashman and lala123912 Mar 3, 2021
@jmguzik
Copy link
Contributor Author

@jmguzik jmguzik commented Mar 3, 2021

@ehashman I hope all your comments are now addressed.

@shubheksha
Copy link
Contributor

@shubheksha shubheksha commented Mar 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 5, 2021
@shubheksha shubheksha removed their assignment Mar 5, 2021
Copy link
Member

@ehashman ehashman left a comment

/lgtm

@ehashman ehashman moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Mar 5, 2021
@ehashman ehashman moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 5, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 11, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmguzik, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 16, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit a951e87 into kubernetes:master Mar 16, 2021
14 checks passed
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/instrumentation sig/node size/S triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

6 participants