Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: etcd_object_counts->apiserver_storage_object_counts(stable) #99785

Merged
merged 1 commit into from Mar 9, 2021

Conversation

erain
Copy link
Contributor

@erain erain commented Mar 4, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

#98270 (comment)

Which issue(s) this PR fixes:

Fixes #98270

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Rename metrics `etcd_object_counts` to `apiserver_storage_object_counts` and mark it as stable. The original `etcd_object_counts` metrics name is marked as "Deprecated" and will be removed in the future. 

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/1209-metrics-stability

@k8s-ci-robot k8s-ci-robot added release-note do-not-merge/invalid-commit-message kind/feature size/S cncf-cla: yes do-not-merge/needs-sig needs-triage needs-priority labels Mar 4, 2021
@erain
Copy link
Contributor Author

@erain erain commented Mar 4, 2021

/assign @logicalhan

@erain
Copy link
Contributor Author

@erain erain commented Mar 4, 2021

/sig instrumentation api-machinery

@k8s-ci-robot k8s-ci-robot added sig/instrumentation sig/api-machinery area/apiserver and removed do-not-merge/needs-sig labels Mar 4, 2021
@k8s-ci-robot k8s-ci-robot added area/test sig/testing labels Mar 4, 2021
@erain
Copy link
Contributor Author

@erain erain commented Mar 4, 2021

Thanks for the review @logicalhan ! All comments addressed.

@erain
Copy link
Contributor Author

@erain erain commented Mar 4, 2021

/retest

@caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented Mar 4, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted and removed needs-triage labels Mar 4, 2021
@logicalhan
Copy link
Contributor

@logicalhan logicalhan commented Mar 6, 2021

@brancz wants this to be named apiserver_storage_objects but actually I am okay with apiserver_storage_object_counts as a convention for gauge counters.

/hold
(wait on @brancz's reply)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold label Mar 6, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase label Mar 6, 2021
@logicalhan
Copy link
Contributor

@logicalhan logicalhan commented Mar 6, 2021

@erain, can you amend the commit message? It seems that # is forbidden in commit messages.

@k8s-ci-robot k8s-ci-robot removed do-not-merge/invalid-commit-message needs-rebase labels Mar 8, 2021
@erain
Copy link
Contributor Author

@erain erain commented Mar 8, 2021

@erain, can you amend the commit message? It seems that # is forbidden in commit messages.

Thanks. I've updated the commit message and also rebased on master. (It seems another stable metrics got merged before this one :D)

Copy link
Contributor

@logicalhan logicalhan left a comment

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added lgtm approved labels Mar 8, 2021
- rename etcd_object_counts to apiserver_storage_object_counts

CONTEXT kubernetes#98270
FIXES kubernetes#98270
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 8, 2021
@logicalhan
Copy link
Contributor

@logicalhan logicalhan commented Mar 9, 2021

/priority important-soon
/hold cancel

@k8s-ci-robot k8s-ci-robot added priority/important-soon and removed do-not-merge/hold needs-priority labels Mar 9, 2021
Copy link
Contributor

@logicalhan logicalhan left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erain, logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit afca3da into kubernetes:master Mar 9, 2021
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 9, 2021
@erain erain deleted the issue/98270 branch Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apiserver area/test cncf-cla: yes kind/feature lgtm priority/important-soon release-note sig/api-machinery sig/instrumentation sig/testing size/S triage/accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants