Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg/kubelet/prober to structured logging #99830

Conversation

krzysiekg
Copy link
Contributor

@krzysiekg krzysiekg commented Mar 5, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate pkg/kubelet/prober to structured logging

Which issue(s) this PR fixes:

Ref #98976

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup size/M cncf-cla: yes do-not-merge/needs-sig needs-triage labels Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 5, 2021

Hi @krzysiekg. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test needs-priority labels Mar 5, 2021
@krzysiekg
Copy link
Contributor Author

@krzysiekg krzysiekg commented Mar 5, 2021

/sig node
/priority important-soon

@k8s-ci-robot k8s-ci-robot added sig/node priority/important-soon area/kubelet and removed do-not-merge/needs-sig needs-priority labels Mar 5, 2021
@@ -193,8 +192,8 @@ func (m *manager) AddPod(pod *v1.Pod) {
if c.LivenessProbe != nil {
key.probeType = liveness
if _, ok := m.workers[key]; ok {
klog.Errorf("Liveness probe already exists! %v - %v",
format.Pod(pod), c.Name)
klog.ErrorS(nil, "Liveness probe already exists for container",
Copy link
Member

@yuzhiquan yuzhiquan Mar 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That 's will be result in

I0102 15:04:05.067890    1234 prober_manager.go:956] "Liveness probe already exists for container"

beacuse err == nil will result in this

Copy link
Contributor

@serathius serathius Mar 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzhiquan Problem you are mentioning should be fixed separately to migration. Let's continue with migration as described in migration guide.

Copy link
Member

@yuzhiquan yuzhiquan Mar 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzhiquan Problem you are mentioning should be fixed separately to migration. Let's continue with migration as described in migration guide.

Sure.

@serathius
Copy link
Contributor

@serathius serathius commented Mar 5, 2021

Structured logging migration part looks good to me.

@shubheksha
Copy link
Contributor

@shubheksha shubheksha commented Mar 5, 2021

/triage accepted
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test triage/accepted and removed needs-ok-to-test needs-triage labels Mar 5, 2021
@shubheksha
Copy link
Contributor

@shubheksha shubheksha commented Mar 5, 2021

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added the sig/instrumentation label Mar 5, 2021
@krzysiekg krzysiekg force-pushed the structured_logging_pkg_kubelet_prober branch from 9491b5d to 86b0efc Compare Mar 5, 2021
@krzysiekg
Copy link
Contributor Author

@krzysiekg krzysiekg commented Mar 5, 2021

/retest

@ehashman ehashman added this to Needs Reviewer in SIG Node PR Triage Mar 5, 2021
Copy link
Member

@ehashman ehashman left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 5, 2021
@krzysiekg
Copy link
Contributor Author

@krzysiekg krzysiekg commented Mar 5, 2021

@serathius I removed changes not related to structured logging migration from this PR. Could you give it a formal lgtm label?

@ehashman ehashman moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 5, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Mar 5, 2021
@krzysiekg
Copy link
Contributor Author

@krzysiekg krzysiekg commented Mar 5, 2021

/assign @klueska

@serathius
Copy link
Contributor

@serathius serathius commented Mar 6, 2021

@krzysiekg Yes, LGTM
/lgtm

@ehashman
Copy link
Member

@ehashman ehashman commented Mar 11, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
@mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Mar 16, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krzysiekg, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 76b29c4 into kubernetes:master Mar 16, 2021
14 checks passed
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/instrumentation sig/node size/M triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

8 participants