Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate kubelet/preemption and kubelet/logs to structured logging #99848

Merged

Conversation

qingwave
Copy link
Contributor

@qingwave qingwave commented Mar 5, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate pkg/kubelet/preemption/preemption.go and pkg/kubelet/logs/container_log_manager.go to structured logging

Which issue(s) this PR fixes:

Ref #98976

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup size/S do-not-merge/release-note-label-needed cncf-cla: yes do-not-merge/needs-sig needs-triage needs-priority needs-ok-to-test labels Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 5, 2021

Hi @qingwave. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node and removed do-not-merge/needs-sig labels Mar 5, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Mar 5, 2021
@qingwave qingwave force-pushed the structred-log-kubelet-preemption branch from ecf1571 to b01324a Compare Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Mar 5, 2021
Copy link
Member

@ehashman ehashman left a comment

/ok-to-test
/priority important-soon
/triage accepted

Please update your release note as well. No calls to Fatal were replaced, so there is no Action Required.

pkg/kubelet/logs/container_log_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/logs/container_log_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/preemption/preemption.go Outdated Show resolved Hide resolved
pkg/kubelet/preemption/preemption.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added priority/important-soon ok-to-test triage/accepted and removed needs-ok-to-test needs-priority needs-triage labels Mar 5, 2021
@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 5, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold release-note and removed release-note-action-required labels Mar 6, 2021
@qingwave qingwave force-pushed the structred-log-kubelet-preemption branch from b01324a to 9d0284c Compare Mar 6, 2021
@qingwave
Copy link
Contributor Author

@qingwave qingwave commented Mar 6, 2021

/hold

until release note unnecessary ACTION REQUIRED gets fixed

@ehashman fiexed as review

@qingwave qingwave force-pushed the structred-log-kubelet-preemption branch from 9d0284c to 8f2d913 Compare Mar 6, 2021
@qingwave
Copy link
Contributor Author

@qingwave qingwave commented Mar 6, 2021

/retest

@ehashman
Copy link
Member

@ehashman ehashman commented Mar 8, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold label Mar 8, 2021
@ehashman ehashman moved this from Waiting on Author to Needs Reviewer in SIG Node PR Triage Mar 8, 2021
@ehashman ehashman moved this from Waiting on Author to Needs Reviewer in Structured Logging Migration for Kubelet, 1.21 Mar 8, 2021
Copy link
Member

@ehashman ehashman left a comment

/lgtm

@ehashman ehashman moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Mar 8, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 8, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 8, 2021
@qingwave
Copy link
Contributor Author

@qingwave qingwave commented Mar 10, 2021

/assign @mrunalp
Needs approve label

@serathius
Copy link
Contributor

@serathius serathius commented Mar 10, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 10, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, qingwave

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 97f59e9 into kubernetes:master Mar 16, 2021
14 checks passed
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/node size/S triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

5 participants