Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg/kubelet/kubelet.go to structured logging #99861

Merged
merged 1 commit into from Mar 18, 2021

Conversation

navidshaikh
Copy link
Member

@navidshaikh navidshaikh commented Mar 5, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate pkg/kubelet/kubelet.go to structured logging

Which issue(s) this PR fixes:

part of #98976

Special notes for your reviewer:

  • refactoring is needed for logging multiple pods using klog, which is taken care by #99799 and same PR will carry the migration of code in this file using format.Pods.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig node instrumentation
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup size/L sig/node sig/instrumentation priority/important-soon cncf-cla: yes needs-triage labels Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 5, 2021

Hi @navidshaikh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test area/kubelet labels Mar 5, 2021
@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and yifan-gu Mar 5, 2021
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
@navidshaikh
Copy link
Member Author

@navidshaikh navidshaikh commented Mar 5, 2021

/cc @ehashman @serathius

@k8s-ci-robot k8s-ci-robot requested review from ehashman and serathius Mar 5, 2021
Copy link
Member

@ehashman ehashman left a comment

/ok-to-test
/triage accepted

pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test triage/accepted and removed needs-ok-to-test needs-triage labels Mar 5, 2021
@ehashman ehashman added this to Waiting on Author in SIG Node PR Triage Mar 5, 2021
@navidshaikh navidshaikh requested a review from ehashman Mar 7, 2021
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 9, 2021
@serathius
Copy link
Contributor

@serathius serathius commented Mar 9, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 9, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 11, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
pkg/kubelet/kubelet.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 17, 2021
@navidshaikh
Copy link
Member Author

@navidshaikh navidshaikh commented Mar 17, 2021

/test pull-kubernetes-e2e-kind

@navidshaikh navidshaikh moved this from Needs Approver to Needs Reviewer in Structured Logging Migration for Kubelet, 1.21 Mar 17, 2021
@kikisdeliveryservice
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice commented Mar 17, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 17, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Needs Reviewer to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 17, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 17, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, navidshaikh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 17, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 17, 2021

/retest

@navidshaikh
Copy link
Member Author

@navidshaikh navidshaikh commented Mar 17, 2021

/test pull-kubernetes-e2e-kind-ipv6

@mrunalp mrunalp moved this from Needs Approver to Done in Structured Logging Migration for Kubelet, 1.21 Mar 17, 2021
@fejta-bot
Copy link

@fejta-bot fejta-bot commented Mar 18, 2021

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit e9632d9 into kubernetes:master Mar 18, 2021
14 checks passed
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 18, 2021
@navidshaikh navidshaikh deleted the pr/slog-kubelet branch Mar 18, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/instrumentation sig/node size/L triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

7 participants