Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg/kubelet/pluginmanager to structured logging #99885

Merged

Conversation

qingwave
Copy link
Contributor

@qingwave qingwave commented Mar 6, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Migrate pkg/kubelet/pluginmanager to structured logging

Which issue(s) this PR fixes:

Ref #98976

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note kind/cleanup size/M cncf-cla: yes do-not-merge/needs-sig needs-triage needs-priority needs-ok-to-test labels Mar 6, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 6, 2021

Hi @qingwave. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node and removed do-not-merge/needs-sig labels Mar 6, 2021
@k8s-ci-robot k8s-ci-robot requested review from mrunalp and yifan-gu Mar 6, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 8, 2021

/ok-to-test
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added ok-to-test triage/accepted priority/important-soon and removed needs-ok-to-test needs-triage needs-priority labels Mar 8, 2021
@ehashman ehashman moved this from Waiting on Author to Needs Reviewer in Structured Logging Migration for Kubelet, 1.21 Mar 8, 2021
@k8s-ci-robot k8s-ci-robot requested a review from serathius Mar 8, 2021
@ehashman ehashman moved this from Needs Reviewer to Waiting on Author in Structured Logging Migration for Kubelet, 1.21 Mar 8, 2021
@ehashman ehashman added this to Waiting on Author in SIG Node PR Triage Mar 8, 2021
@qingwave qingwave force-pushed the structred-log-kubelet-pluginmanager branch 2 times, most recently from f0a1665 to cd8c2cc Compare Mar 9, 2021
@qingwave qingwave force-pushed the structred-log-kubelet-pluginmanager branch from cd8c2cc to fd5f929 Compare Mar 10, 2021
@qingwave
Copy link
Contributor Author

@qingwave qingwave commented Mar 10, 2021

@serathius Fixed as suggested above.

@qingwave qingwave force-pushed the structred-log-kubelet-pluginmanager branch from fd5f929 to f405c79 Compare Mar 10, 2021
@serathius
Copy link
Contributor

@serathius serathius commented Mar 10, 2021

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 10, 2021
@serathius
Copy link
Contributor

@serathius serathius commented Mar 10, 2021

/assign @mrunalp

@serathius
Copy link
Contributor

@serathius serathius commented Mar 10, 2021

/assign @taragu

@ehashman ehashman moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Mar 10, 2021
@ehashman ehashman moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 11, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 11, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 11, 2021
@mrunalp
Copy link
Contributor

@mrunalp mrunalp commented Mar 11, 2021

/approve

@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, qingwave

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0f1db58 into kubernetes:master Mar 12, 2021
13 of 14 checks passed
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 12, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/node size/M triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

6 participants