Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg/kubelet/cm/topologymanager to structure logging #99969

Merged
merged 1 commit into from Mar 16, 2021

Conversation

knabben
Copy link
Member

@knabben knabben commented Mar 9, 2021

What type of PR is this?

/kind feature
/sig instrumentation
/sig node

What this PR does / why we need it:

Migrate pkg/kubelet/cm/topologymanager/

Which issue(s) this PR fixes:

Rels #98976

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none kind/feature sig/instrumentation size/M sig/node cncf-cla: yes needs-triage needs-priority labels Mar 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from krmayankk and nolancon Mar 9, 2021
@ehashman ehashman added this to Triage in SIG Node PR Triage Mar 9, 2021
pkg/kubelet/cm/topologymanager/topology_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/topologymanager/scope_pod.go Outdated Show resolved Hide resolved
@shubheksha shubheksha moved this from Needs Reviewer to Waiting on Author in Structured Logging Migration for Kubelet, 1.21 Mar 9, 2021
@shubheksha
Copy link
Contributor

@shubheksha shubheksha commented Mar 9, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted priority/important-soon and removed needs-triage needs-priority labels Mar 9, 2021
pkg/kubelet/cm/topologymanager/fake_topology_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/topologymanager/fake_topology_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/topologymanager/fake_topology_manager.go Outdated Show resolved Hide resolved
pkg/kubelet/cm/topologymanager/scope.go Outdated Show resolved Hide resolved
@ehashman ehashman moved this from Triage to Waiting on Author in SIG Node PR Triage Mar 10, 2021
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

this is a user facing change, please update description so this gets a release note. thanks!

@k8s-ci-robot k8s-ci-robot added release-note and removed release-note-none labels Mar 12, 2021
@kikisdeliveryservice kikisdeliveryservice dismissed their stale review Mar 12, 2021

note added - thank you!! :)

@knabben
Copy link
Member Author

@knabben knabben commented Mar 12, 2021

/retest

Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

caught one thing going thru

pkg/kubelet/cm/topologymanager/scope_container.go Outdated Show resolved Hide resolved
Copy link
Member

@kikisdeliveryservice kikisdeliveryservice left a comment

re-reviewed and all requested changes made. thank you!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 12, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Waiting on Author to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 12, 2021
@kikisdeliveryservice kikisdeliveryservice moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Mar 12, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 12, 2021

/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 12, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knabben, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 16, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 81a1a79 into kubernetes:master Mar 16, 2021
14 checks passed
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/feature lgtm priority/important-soon release-note-none sig/instrumentation sig/node size/M triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

6 participants