Migrate pkg/kubelet/cm/topologymanager to structure logging #99969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
shubheksha
suggested changes
Mar 9, 2021
shubheksha
moved this from Needs Reviewer
to Waiting on Author
in Structured Logging Migration for Kubelet, 1.21
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
ehashman
suggested changes
Mar 10, 2021
kikisdeliveryservice
previously requested changes
Mar 11, 2021
this is a user facing change, please update description so this gets a release note. thanks!
k8s-ci-robot
added
release-note
|
/retest |
kikisdeliveryservice
reviewed
Mar 12, 2021
kikisdeliveryservice
reviewed
Mar 12, 2021
re-reviewed and all requested changes made. thank you!
/lgtm
kikisdeliveryservice
moved this from Waiting on Author
to Needs Approver
in Structured Logging Migration for Kubelet, 1.21
kikisdeliveryservice
moved this from Waiting on Author
to Needs Approver
in SIG Node PR Triage
|
/milestone v1.21 |
mrunalp
approved these changes
Mar 16, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knabben, mrunalp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Structured Logging Migration for Kubelet, 1.21
automation
moved this from Needs Approver
to Done
Mar 16, 2021
k8s-ci-robot
added
release-note-none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
What type of PR is this?
/kind feature
/sig instrumentation
/sig node
What this PR does / why we need it:
Migrate
pkg/kubelet/cm/topologymanager/Which issue(s) this PR fixes:
Rels #98976
Special notes for your reviewer:
Does this PR introduce a user-facing change?