Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate cmd/kubelet and pkg/kubelet/cadvisor , pkg/kubelet/cri/remote/util , pkg/kubelet/images to structured logging #99994

Merged
merged 1 commit into from Mar 16, 2021

Conversation

AfrouzMashayekhi
Copy link
Contributor

@AfrouzMashayekhi AfrouzMashayekhi commented Mar 9, 2021

What type of PR is this?

/kind cleanup
/sig instrumentation
/sig node

What this PR does / why we need it:

Migrate cmd/kubelet/+ pkg/kubelet/cadvisor/cadvisor_linux.go + pkg/kubelet/cri/remote/util/util_unix.go + pkg/kubelet/images/image_manager.go to structured logging

Which issue(s) this PR fixes:

Special notes for your reviewer:

part of kubernetes/enhancements#1602
As it is related to log, change the log here to structured log.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none kind/cleanup size/S sig/instrumentation sig/node cncf-cla: yes needs-triage needs-priority labels Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 9, 2021

Hi @AfrouzMashayekhi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test area/kubelet labels Mar 9, 2021
@k8s-ci-robot k8s-ci-robot requested review from resouer and sjenning Mar 9, 2021
@AfrouzMashayekhi
Copy link
Contributor Author

@AfrouzMashayekhi AfrouzMashayekhi commented Mar 9, 2021

/cc @serathius

@k8s-ci-robot k8s-ci-robot requested a review from serathius Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added release-note and removed release-note-none labels Mar 9, 2021
@AfrouzMashayekhi AfrouzMashayekhi force-pushed the sl-cmd-kubelet branch 2 times, most recently from b6f9c11 to e83c8f0 Compare Mar 9, 2021
@@ -24,19 +24,19 @@ import (
func watchForLockfileContention(path string, done chan struct{}) error {
watcher, err := inotify.NewWatcher()
if err != nil {
klog.Errorf("unable to create watcher for lockfile: %v", err)
klog.ErrorS(err, "unable to create watcher for lockfile")
Copy link
Contributor

@krzysiekg krzysiekg Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messages should start from a capital letter, to comply with good practices

return err
}
if err = watcher.AddWatch(path, inotify.InOpen|inotify.InDeleteSelf); err != nil {
klog.Errorf("unable to watch lockfile: %v", err)
klog.ErrorS(err, "unable to watch lockfile")
Copy link
Contributor

@krzysiekg krzysiekg Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messages should start from a capital letter, to comply with good practices

@serathius
Copy link
Contributor

@serathius serathius commented Mar 9, 2021

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Mar 9, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 9, 2021
@serathius
Copy link
Contributor

@serathius serathius commented Mar 9, 2021

/assign @yujuhong

Copy link
Member

@ehashman ehashman left a comment

/lgtm
/priority important-soon
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-soon triage/accepted and removed needs-priority needs-triage labels Mar 9, 2021
@ehashman ehashman moved this from Needs Reviewer to Needs Approver in Structured Logging Migration for Kubelet, 1.21 Mar 9, 2021
@ehashman ehashman moved this from Triage to Needs Approver in SIG Node PR Triage Mar 9, 2021
@ehashman
Copy link
Member

@ehashman ehashman commented Mar 9, 2021

/retest

1 similar comment
@AfrouzMashayekhi
Copy link
Contributor Author

@AfrouzMashayekhi AfrouzMashayekhi commented Mar 10, 2021

/retest

@serathius
Copy link
Contributor

@serathius serathius commented Mar 10, 2021

/retest
/milestone v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 10, 2021
@AfrouzMashayekhi AfrouzMashayekhi requested a review from ehashman Mar 16, 2021
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Mar 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AfrouzMashayekhi, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved label Mar 16, 2021
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Mar 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5ead6af into kubernetes:master Mar 16, 2021
14 checks passed
Structured Logging Migration for Kubelet, 1.21 automation moved this from Needs Approver to Done Mar 16, 2021
@k8s-ci-robot k8s-ci-robot added release-note-none and removed release-note labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/kubelet cncf-cla: yes kind/cleanup lgtm ok-to-test priority/important-soon release-note-none sig/instrumentation sig/node size/S triage/accepted
Development

Successfully merging this pull request may close these issues.

None yet

7 participants