From e9a03cb4cb01a331da5967bff89ec5a94ae13d0e Mon Sep 17 00:00:00 2001 From: Francis Laniel Date: Wed, 6 Dec 2023 17:17:57 +0100 Subject: [PATCH] addons: Update Inspektor Gadget entrypoint and cleanup. Inspektor Gadget container entrypoint and cleanup programs were translated from bash to golang [1, 2]. Upstream YAML file used to deploy was updated to reflect this change [3]. Sadly, it was not the case for the YAML used to deploy the minikube addon which leaded to troubles [4, 5, 6]. The present commit updates the minikube addon YAML to use the correct programs as entrypoint and cleanup. Signed-off-by: Francis Laniel [1]: https://github.com/inspektor-gadget/inspektor-gadget/pull/2207/commits/b268d38758cfc175a9fc7bddea82c937e9668542 [2]: https://github.com/inspektor-gadget/inspektor-gadget/pull/2207/commits/3dba83f2ebe8cb8d08dbe1b81ab0cb24531fe5b0 [3]: https://github.com/inspektor-gadget/inspektor-gadget/pull/2207/commits/992399f2ddd3392615860b75d6251ac3e1706231#diff-0927404b80a3c13f63de64a0c7af1833ba3dfd4b4e1dd07b09cb8216c7f033fcR46 [4]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio_arm64.html#fail_TestAddons/parallel/InspektorGadget [5]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/Docker_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget [6]: https://storage.googleapis.com/minikube-builds/logs/17731/32161/KVM_Linux_crio.html#fail_TestAddons/parallel/InspektorGadget --- deploy/addons/inspektor-gadget/ig-daemonset.yaml.tmpl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/deploy/addons/inspektor-gadget/ig-daemonset.yaml.tmpl b/deploy/addons/inspektor-gadget/ig-daemonset.yaml.tmpl index e358f9fe0c68..77141e7fced7 100644 --- a/deploy/addons/inspektor-gadget/ig-daemonset.yaml.tmpl +++ b/deploy/addons/inspektor-gadget/ig-daemonset.yaml.tmpl @@ -32,12 +32,12 @@ spec: terminationMessagePolicy: FallbackToLogsOnError image: {{.CustomRegistries.InspektorGadget | default .ImageRepository | default .Registries.InspektorGadget }}{{.Images.InspektorGadget}} imagePullPolicy: "Always" - command: [ "/entrypoint.sh" ] + command: [ "/entrypoint" ] lifecycle: preStop: exec: command: - - "/cleanup.sh" + - "/cleanup" readinessProbe: periodSeconds: 5 timeoutSeconds: 2