Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add addon registry build integration test #10790

Open
spowelljr opened this issue Mar 11, 2021 · 6 comments
Open

Add addon registry build integration test #10790

spowelljr opened this issue Mar 11, 2021 · 6 comments
Labels
area/testing kind/process Process oriented issues, like setting up CI lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@spowelljr
Copy link
Member

spowelljr commented Mar 11, 2021

Currently, the addon registry integration test tests against the Kubernetes client.
https://github.com/kubernetes/minikube/blob/master/test/integration/addons_test.go#L224

We should add a new test where we actually build and push the image to the registry.

To check if the image is pushed to the registry use the following command:

% curl -X GET http://$(minikube ip):5000/v2/_catalog 
{"repositories":["test-img"]}
@spowelljr spowelljr added area/testing priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 11, 2021
@spowelljr spowelljr changed the title Add real addon registry integration test Add addon registry build integration test Mar 11, 2021
@anencore94
Copy link
Contributor

Hi @spowelljr !, If you don't mind, would I take this issue ?

And I guess you mean the Line #L224 not #L140, right?

func validateRegistryAddon(ctx context.Context, t *testing.T, profile string) {

Also, I think testing docker push and docker pull the image to the registry is fine, building the new image on test time is not what we want to test actually. I think we could use pre-built docker image with .tar or just pull from docker hub and then push it to our addon-registry

By the way, If I make the test, I wonder do we have to push image in some pod or not(just in the host). I think it is just fine to test push in the host machine(=minikube), if it has docker cli binary or some other requirements I missed.

@medyagh
Copy link
Member

medyagh commented Mar 15, 2021

@anencore94 go for it !

@medyagh medyagh added the kind/process Process oriented issues, like setting up CI label Mar 15, 2021
@spowelljr
Copy link
Member Author

@anencore94 Yes, I did mean line 224 and not 140, that was my mistake.

@anencore94
Copy link
Contributor

/assign

@spowelljr spowelljr added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Apr 21, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2021
@spowelljr spowelljr added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 4, 2021
@spowelljr
Copy link
Member Author

spowelljr commented Aug 4, 2021

@anencore94 I've unassigned you since I closed your PR, but if you're still interested on working on this feel free to reassign yourself.

@spowelljr spowelljr added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing kind/process Process oriented issues, like setting up CI lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants