New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add addon registry build integration test #10790
Comments
Hi @spowelljr !, If you don't mind, would I take this issue ? And I guess you mean the Line #L224 not #L140, right? minikube/test/integration/addons_test.go Line 224 in ff0e25a
Also, I think testing By the way, If I make the test, I wonder do we have to push image in some pod or not(just in the host). I think it is just fine to test push in the host machine(=minikube), if it has docker cli binary or some other requirements I missed. |
@anencore94 go for it ! |
@anencore94 Yes, I did mean line 224 and not 140, that was my mistake. |
/assign |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
@anencore94 I've unassigned you since I closed your PR, but if you're still interested on working on this feel free to reassign yourself. |
Currently, the addon registry integration test tests against the Kubernetes client.
https://github.com/kubernetes/minikube/blob/master/test/integration/addons_test.go#L224
We should add a new test where we actually build and push the image to the registry.
To check if the image is pushed to the registry use the following command:
The text was updated successfully, but these errors were encountered: