New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MacOS ISO build steps #12539
Update MacOS ISO build steps #12539
Conversation
For issue kubernetes#11902 Two changes required to get MacOS ISO builds working: 1. Include a 'go module' compatible golang environment in the buildroot docker image 2. Run the build within a shell environment to have $PWD set
Welcome @cameronbrunner! |
Hi @cameronbrunner. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cameronbrunner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
I'm cool with updating the base image to ubuntu 20.04, thanks for your help fixing this! |
Fixes issue #11902
Two changes required to get MacOS ISO builds working:
buildroot docker image
It may be worthwhile to update to Ubuntu 20.04.