Fix(node): delete config #13220
Fix(node): delete config #13220
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
cncf-cla: no
|
Welcome @ayshiff! |
|
Hi @ayshiff. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ayshiff The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
pkg/minikube/node/node.go
Outdated
| @@ -24,6 +24,7 @@ import ( | |||
| "github.com/pkg/errors" | |||
| "github.com/spf13/viper" | |||
|
|
|||
| apiErrors "k8s.io/apimachinery/pkg/api/errors" | |||
There was a problem hiding this comment.
this is not right, that error is for kuberentes not for minikube
There was a problem hiding this comment.
I thought that the error we are looking for is the one that we get in response to the kubectl delete Command (client.CoreV1().Nodes().Delete call) which is: Error from server (NotFound): nodes "minikube-m%” not found.
What would be the correct approach? Do we have another way to check that the node exists?
Can we assume that if the node doesn’t have an IP address, it doesn’t exist? I tried that in my last commit.
func drainNode(cc config.ClusterConfig, name string) (*config.Node, error) {
n, index, err := Retrieve(cc, name)
// ...
// Exit if the node doesn't have an IP address
if len(n.IP) == 0 {
return n, &NotExistError{Name: n.Name, Index: index}
}
// ...
}
k8s-ci-robot
added
size/M
|
I signed the CLA. |
k8s-ci-robot
added
cncf-cla: yes
|
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
i honestly can't tell if this is fixed or not. Is it in 1.29? |
Fixes #12677
Resolves the "ghost node" issue.
This patch provides a way to delete a node config even if the node is not found.
I would like to add some integration tests under
TestMultiNode/DeleteNodebut I would like to have some advice on how to proceed. :)