New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GPU support to minikube. #2936

Merged
merged 3 commits into from Jul 9, 2018

Conversation

Projects
None yet
7 participants
@mindprince
Copy link
Member

mindprince commented Jun 26, 2018

Fixes #2115.

Testing this PR locally:

See the instructions added to docs/gpu.md in this PR. Even if you don't satisfy the prerequisites mentioned there, it would be useful to run these and check if the error messages returned are useful.

# From your minikube checkout
git fetch origin pull/2936/head:gpu-support
git checkout gpu-support

# Build the docker machine plugin
make out/docker-machine-driver-kvm2
cp out/docker-machine-driver-kvm2 /usr/local/bin/docker-machine-driver-kvm2

# Build minikube
make out/minikube

# Run minikube with GPUs
out/minikube start --vm-driver kvm2 --gpu --logtostderr
@mindprince

This comment has been minimized.

Copy link
Member

mindprince commented Jun 26, 2018

/assign @vishh

@minikube-bot

This comment has been minimized.

Copy link
Collaborator

minikube-bot commented Jun 26, 2018

Can one of the admins verify this patch?

@mindprince mindprince force-pushed the mindprince:gpu-support branch 2 times, most recently from b65beec to 3dc19ac Jun 26, 2018

@vishh

This comment has been minimized.

Copy link
Member

vishh commented Jun 27, 2018

This PR overall lgtm. I'd recommend having some of the users wanting this feature in #2115 to try this out as well.

@vishh

This comment has been minimized.

Copy link
Member

vishh commented Jun 27, 2018

What would be the testing and maintenance story for this feature? If we need community help with maintenance, should we mark it as alpha/experimental until we can demonstrate sustained usage and maintenance?

@mindprince mindprince force-pushed the mindprince:gpu-support branch from 3dc19ac to 74e1908 Jun 27, 2018

@k8s-ci-robot k8s-ci-robot added size/XL and removed size/L labels Jun 27, 2018

@mindprince mindprince force-pushed the mindprince:gpu-support branch from 94cfb5e to 741dc5f Jun 27, 2018

@mindprince mindprince force-pushed the mindprince:gpu-support branch from 741dc5f to a79cf6c Jun 27, 2018

@mindprince mindprince referenced this pull request Jun 27, 2018

Closed

GPU support #2115

@mindprince

This comment has been minimized.

Copy link
Member

mindprince commented Jun 27, 2018

@mindprince

This comment has been minimized.

Copy link
Member

mindprince commented Jun 27, 2018

This PR overall lgtm. I'd recommend having some of the users wanting this feature in #2115 to try this out as well.

Commented on that issue.

What would be the testing and maintenance story for this feature? If we need community help with maintenance, should we mark it as alpha/experimental until we can demonstrate sustained usage and maintenance?

The doc and help text say experimental. I would love to e2e test this but since GCE's nested virtualization doesn't have a virtual IOMMU, so we can't test this on GCE. If people have other ideas, I am all ears.

@mindprince mindprince force-pushed the mindprince:gpu-support branch from a79cf6c to c660256 Jun 27, 2018

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 27, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mindprince
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aaron-prindle

Assign the PR to them by writing /assign @aaron-prindle in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dlorenc

This comment has been minimized.

Copy link
Contributor

dlorenc commented Jun 27, 2018

Thanks! The PR looks good to me. I'd like to think about the testing for another day or so and see if we can come up with something.

@mindprince mindprince force-pushed the mindprince:gpu-support branch from c660256 to f4bd357 Jun 28, 2018

@mindprince

This comment has been minimized.

Copy link
Member

mindprince commented Jun 29, 2018

Ping.

@dlorenc

dlorenc approved these changes Jul 4, 2018

@dlorenc

This comment has been minimized.

Copy link
Contributor

dlorenc commented Jul 4, 2018

@minikube-bot OK to test

@dlorenc dlorenc merged commit db90809 into kubernetes:master Jul 9, 2018

7 of 14 checks passed

Linux-None Jenkins
Details
Linux-VirtualBox Jenkins
Details
Minishift-Linux-KVM Jenkins
Details
Linux-Virtualbox Jenkins
Details
Windows-Kubeadm-CRI-O Jenkins
Details
Windows-Virtualbox Jenkins
Details
tide Not mergeable. Needs approved, lgtm labels.
Details
Jenkins Cross Build Build finished. No test results found.
Details
Linux-Container Jenkins
Details
Linux-KVM Jenkins
Details
OSX-Hyperkit Jenkins
Details
OSX-Virtualbox Jenkins
Details
cla/linuxfoundation mindprince authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment