New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow certificates to be optionally embedded in .kube/config #3065

Merged
merged 1 commit into from Sep 3, 2018

Conversation

Projects
None yet
6 participants
@jstangroome
Contributor

jstangroome commented Aug 10, 2018

Opt-in with minikube config set embed-certs true. Similar to the
behaviour of kubectl config set-credentials --embed-certs.

Enables Minikube on Windows to produce a .kube/config file that
can be shared directly with kubectl inside the Windows Subsystem
for Linux (WSL) without needing to perform additional translation
of the certificate paths within the configuration file.

Fixes #3064

Allow certificates to be optionally embedded in .kube/config
Opt-in with `minikube config set embed-certs true`. Similar to the
behaviour of `kubectl config set-credentials --embed-certs`.

Enables Minikube on Windows to produce a .kube/config file that
can be shared directly with kubectl inside the Windows Subsystem
for Linux (WSL) without needing to perform additional translation
of the certificate paths within the configuration file.
@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Aug 10, 2018

Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jstangroome
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Aug 10, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jstangroome
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot

This comment has been minimized.

Show comment
Hide comment
@minikube-bot

minikube-bot Aug 10, 2018

Collaborator

Can one of the admins verify this patch?

Collaborator

minikube-bot commented Aug 10, 2018

Can one of the admins verify this patch?

@jstangroome

This comment has been minimized.

Show comment
Hide comment
@jstangroome

jstangroome Aug 10, 2018

Contributor

While I'd love to see embedded certificates in the .kube/config file become the default behaviour, starting with an opt-in-only approach seems least disruptive.

Contributor

jstangroome commented Aug 10, 2018

While I'd love to see embedded certificates in the .kube/config file become the default behaviour, starting with an opt-in-only approach seems least disruptive.

@jstangroome

This comment has been minimized.

Show comment
Hide comment
@jstangroome

jstangroome Aug 10, 2018

Contributor

/assign @dlorenc

Contributor

jstangroome commented Aug 10, 2018

/assign @dlorenc

@dlorenc

This comment has been minimized.

Show comment
Hide comment
@dlorenc

dlorenc Aug 14, 2018

Contributor

@minikube-bot OK to test

Contributor

dlorenc commented Aug 14, 2018

@minikube-bot OK to test

@alexellis

This comment has been minimized.

Show comment
Hide comment
@alexellis

alexellis Sep 2, 2018

I could really use this.. @neolit123 any thoughts? How come this patch got "stuck"?

alexellis commented Sep 2, 2018

I could really use this.. @neolit123 any thoughts? How come this patch got "stuck"?

@alexellis

This comment has been minimized.

Show comment
Hide comment
@alexellis

alexellis Sep 2, 2018

@jstangroome with your changes at present, does this make .kube/config portable i.e. without a .minkube directory and separate files?

alexellis commented Sep 2, 2018

@jstangroome with your changes at present, does this make .kube/config portable i.e. without a .minkube directory and separate files?

@jstangroome

This comment has been minimized.

Show comment
Hide comment
@jstangroome

jstangroome Sep 2, 2018

Contributor

@alexellis AFAIK, for running kubectl commands, my change means you only need the .kube/config file and you won't need the .minikube directory.

Contributor

jstangroome commented Sep 2, 2018

@alexellis AFAIK, for running kubectl commands, my change means you only need the .kube/config file and you won't need the .minikube directory.

@alexellis

This comment has been minimized.

Show comment
Hide comment
@alexellis

alexellis Sep 3, 2018

That'd be perfect for my use-case. What is blocking this PR?

alexellis commented Sep 3, 2018

That'd be perfect for my use-case. What is blocking this PR?

@neolit123

This comment has been minimized.

Show comment
Hide comment
@neolit123

neolit123 Sep 3, 2018

Member

What is blocking this PR?

maybe the minikube maintainers can answer that.

Member

neolit123 commented Sep 3, 2018

What is blocking this PR?

maybe the minikube maintainers can answer that.

@dlorenc

dlorenc approved these changes Sep 3, 2018

@dlorenc dlorenc merged commit 9b21d3c into kubernetes:master Sep 3, 2018

6 of 14 checks passed

Linux-None Jenkins
Details
Linux-VirtualBox Jenkins
Details
Linux-Container Jenkins
Details
Linux-Virtualbox Jenkins
Details
Minishift-Linux-KVM Jenkins
Details
Windows-Kubeadm-CRI-O Jenkins
Details
Windows-Virtualbox Jenkins
Details
tide Not mergeable. Needs approved, lgtm labels.
Details
Jenkins Cross Build Build finished. No test results found.
Details
Linux-KVM Jenkins
Details
OSX-Hyperkit Jenkins
Details
OSX-Virtualbox Jenkins
Details
cla/linuxfoundation jstangroome authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jstangroome jstangroome deleted the jstangroome:jstangroome-embed-certs branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment