Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
--extra-config now work for kubeadm as well #3879
This small patch allows us to use
My primary motivation is to run
This patch allows one to do so like this:
This was referenced
Mar 14, 2019
This is quite a convoluted syntax for the check, and it seems that it is duplicating the preflight checks in two different places now. Can see the reason for skipping Docker version check (surely they will name the next version something weird and break it again), but supporting generic parameters to kubeadm might be hard to do. Would rather see something more specific to SystemVerification at this point in time.
hey, @afbjorklund !
An alternative for my generic approach would be similar to what was implemented here: #3892
The problem with that implementation is that minikube will one day become a mess if we start exposing each and every parameter from other tools to it. Also, my approach is future compatible.
That being said, I am neutral to how this get's implemented as long as I can tell minikube to tell kubeadm not to complain about docker versions.
Please tell me if I can help you in any other way!
referenced this pull request
Mar 18, 2019
Hi @tstromberg !
And since travis does not do integration tests, here is my passing output:
This is the command I used to run the tests:
(I must use
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing