Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove arch suffixes in image names #3942

Merged
merged 2 commits into from Mar 26, 2019
Merged

Remove arch suffixes in image names #3942

merged 2 commits into from Mar 26, 2019

Conversation

laozc
Copy link
Contributor

@laozc laozc commented Mar 23, 2019

Removing arch suffixes in image names to make sure image caching
work with kubeadm image pull.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 23, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laozc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: luxas

If they are not already assigned, you can assign the PR to them by writing /assign @luxas in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@laozc laozc force-pushed the image-name branch 5 times, most recently from dfb0422 to 20c842a Compare March 23, 2019 07:54
@laozc
Remove arch suffixes in image names
aeb1605 
Removing arch suffixes in image names to make sure image caching
work with kubeadm since 1.12.0.

Signed-off-by: Zhongcheng Lao <Zhongcheng.Lao@microsoft.com>
afbjorklund
afbjorklund approved these changes Mar 24, 2019
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be possible to go over to manifests like this, instead of explicitly listing architectures.

https://kubernetes.io/docs/concepts/containers/images/#building-multi-architecture-images-with-manifests

It only says that the old image names should be kept for "backward compatibility", but not for how long.

The idea is to generate say pause image which has the manifest for all the arch(es) and say pause-amd64 which is backwards compatible for older configurations or YAML files which may have hard coded the images with suffixes.

Looks like you have already versioned it on Kubernetes 1.12+

Can verify that it works with both docker and podman, at least.

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg tstromberg added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2019
@tstromberg tstromberg merged commit 2a32858 into kubernetes:master Mar 26, 2019
@tstromberg
Copy link
Contributor

Thank you!

@laozc laozc deleted the image-name branch May 16, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tstromberg tstromberg tstromberg approved these changes

@afbjorklund afbjorklund afbjorklund approved these changes

@balopat balopat Awaiting requested review from balopat

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@laozc @minikube-bot @k8s-ci-robot @tstromberg @afbjorklund