Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announce environmental overrides up front #5212

Merged
merged 1 commit into from Aug 27, 2019
Merged

Announce environmental overrides up front #5212

merged 1 commit into from Aug 27, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Aug 27, 2019 •
edited

This helps to address issues like #5207 where the user has forgotten or is not aware of what environment variables may have been previously set. Example run:

😄  minikube v1.3.1 on Darwin 10.14.6
    ▪ MINIKUBE_HOME=/tmp
    ▪ KUBECONFIG=/tmp/.kc
💡  Tip: Use 'minikube start -p <name>' to create a new cluster, or 'minikube delete' to delete this one.
🔄  Starting existing virtualbox VM for "minikube" ...
⌛  Waiting for the host to be provisioned ...

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 27, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
afbjorklund
afbjorklund approved these changes Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@afbjorklund afbjorklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me, I guess we have no secrets in environment variables (would we) ?

@tstromberg
Copy link
Contributor Author

Sounds good to me, I guess we have no secrets in environment variables (would we) ?

Not yet! If we ever do, we can mask it.

@tstromberg tstromberg merged commit 2205bb8 into kubernetes:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund afbjorklund approved these changes

@sharifelgamal sharifelgamal Awaiting requested review from sharifelgamal

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tstromberg @k8s-ci-robot @afbjorklund