upstep docker to version 1.12.1 (default ubuntu shipped) #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Current coverage is 30.14% (diff: 100%)@@ master #525 diff @@
==========================================
Files 38 38
Lines 1589 1589
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 479 479
Misses 1002 1002
Partials 108 108
|
|
Hey thanks for the submission. Kubernetes is still working through some bugs with docker 1.12 so we've held off on upgrading minikube until then. We're currently tracking the progress in this PR #435. If you want to share the docker client with minikube for now, this changed was merged in to allow that #474 |
|
From kubernetes/kubernetes#28698 it sounds like Kubernetes is sticking with Docker 1.11 for the k8s 1.4 release cycle. I'll close this out for now since an update is at least 3 months out :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstep docker from version 1.11.1 towards 1.12.1