Check node pressure & new option "node_ready" for --wait flag #7752

medyagh · 2020-04-17T18:21:39Z

redoing this PR #7611 that was reviewed:

adding detecting different types of pressure, disk, memory, pid, network ...
making pressure a required check since it is a cheap call. and we dont wait on it
adding a new wait component called node_ready

Before this PR : (not veriifying disk pressure)

$ ./out/minikube start --driver=docker 
😄  minikube v1.9.2 on Darwin 10.13.6
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

default new start

😄  minikube v1.9.2 on Darwin 10.13.6
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🕵️   Verifying Kubernetes Components:
    🔎 verifying node conditions ...
    🔎 verifying api server ...
    🔎 verifying system pods ...
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

After this PR : default start

the error is dummy pressure err


😄  minikube v1.9.2 on Darwin 10.13.6
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🕵️   Verifying Kubernetes Components:
    🔎 verifying node conditions ...

❗  The node minikube has ran out of disk space.
💡  Please free up disk or prune images.
🛑  Consider increasing Docker Desktop's disk size.
📘  Documentation: https://docs.docker.com/docker-for-mac/space/


💣  failed to start node: startup failed: Wait failed: node pressure: node has unwanted condition "MemoryPressure" : Reason "KubeletHasSufficientMemory" Message: "kubelet has sufficient memory available"

😿  minikube is exiting due to an error. If the above message is not useful, open an issue:
👉  https://github.com/kubernetes/minikube/issues/new/choose

After this PR : --wait=all

😄  minikube v1.9.2 on Darwin 10.13.6
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🕵️   Verifying Kubernetes Components:
    🔎 verifying node conditions ...
    🔎 verifying api server ...
    🔎 verifying system pods ...
    🔎 verifying default service account ...
    🔎 verifying apps running ...
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

after this pr --wait=false

( will add a required check for node pressure) which is a cheap call

😄  minikube v1.9.2 on Darwin 10.13.6
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🔥  Creating docker container (CPUs=2, Memory=4000MB) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🕵️   Verifying Kubernetes Components:
    🔎 verifying node conditions ...
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

(when I paste the indentation seems wrong but in reality it is good see screenshot)

k8s-ci-robot · 2020-04-17T18:22:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

medyagh · 2020-04-17T20:10:07Z

/ok-to-test

minikube-pr-bot · 2020-04-17T20:36:03Z

kvm2 Driver
Times for minikube: [63.405843113 63.416488064 64.585325637]
Average time for minikube: 63.80255227133333

Times for Minikube (PR 7752): [60.075308506 65.707435917 64.84916928800001]
Average time for Minikube (PR 7752): 63.543971236999994

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7752) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.056036 |           0.052845 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020123 |           0.019365 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003202 |           0.003575 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.646537 |          39.474269 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.491773 |          21.875605 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.510920 |           0.687474 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.070748 |           0.083555 |
| configured to use "minikube"   |           |                    |
|                                |  0.003213 |           0.004272 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [24.146066545999997 25.820354467 25.832684678]
Average time for minikube: 25.266368563666664

Times for Minikube (PR 7752): [25.257579096 24.621588779 25.808672221]
Average time for Minikube (PR 7752): 25.229280032000002

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7752) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.072529 |           0.070520 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002124 |           0.002276 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.055089 |           0.056130 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.181455 |           7.386215 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000157 |           0.000243 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.353560 |          16.929172 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.534069 |           0.002340 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062701 |           0.060424 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004684 |           0.048366 |
+----------------------------------------+-----------+--------------------+

tstromberg

The default output should be reduced if possible.

pkg/addons/addons.go

pkg/minikube/bootstrapper/bsutil/kverify/node_conditions.go

tstromberg · 2020-04-17T20:07:55Z

pkg/minikube/bootstrapper/kubeadm/kubeadm.go

+
+	// starting from minikube v1.10 checking for node pressure is a reuqired check
+	out.T(out.HealthCheck, "Verifying Kubernetes Components:")
+	out.T(out.OptionVerify, "verifying node conditions ...")


Can we remove this line? It seems noisy, and doesn't inform the user any more than the previous line item.

leave this for a follow up PR to refresh the UI

pkg/minikube/bootstrapper/kubeadm/kubeadm.go

pkg/minikube/out/style.go

pkg/minikube/node/start.go

medyagh · 2020-04-17T21:23:54Z

The default output should be reduced if possible.

the default output is in the description

minikube-pr-bot · 2020-04-17T21:25:21Z

kvm2 Driver
Times for minikube: [61.974215126000004 63.268564074000004 62.484849383000004]
Average time for minikube: 62.57587619433334

Times for Minikube (PR 7752): [64.99830263999999 64.48779738 64.863421651]
Average time for Minikube (PR 7752): 64.78317389033333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7752) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.060979 |           0.055513 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018769 |           0.020899 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.002972 |           0.002981 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.475356 |          41.282904 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 19.982336 |          21.005480 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.949756 |           0.945334 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.082673 |           0.086631 |
| configured to use "minikube"   |           |                    |
|                                |  0.003035 |           0.056384 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [23.837959988999998 25.149093815000004 25.191401467]
Average time for minikube: 24.726151756999997

Times for Minikube (PR 7752): [25.26397778700001 25.185194627 25.083634124000007]
Average time for Minikube (PR 7752): 25.177602179333334

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7752) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.071912 |           0.070522 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002279 |           0.002204 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.055512 |           0.053391 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.239794 |           7.155570 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000143 |           0.000160 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 15.824101 |          16.606710 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.470661 |           0.075662 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.059267 |           0.065024 |
| configured to use "minikube"           |           |                    |
|                                        |  0.002483 |           0.061715 |
+----------------------------------------+-----------+--------------------+

medyagh · 2020-04-17T21:36:24Z

/ok-to-test

minikube-pr-bot · 2020-04-17T21:55:30Z

kvm2 Driver
Times for minikube: [66.27467135500001 62.664579117 62.72568314800001]
Average time for minikube: 63.88831120666666

Times for Minikube (PR 7752): [84.727523852 63.79319204600001 64.755546441]
Average time for Minikube (PR 7752): 71.09208744633332

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7752) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055137 |           0.053312 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.020971 |           0.018783 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003908 |           0.002872 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.751236 |          40.338418 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.307182 |          28.119726 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.659805 |                    |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.086031 |           0.081053 |
| configured to use "minikube"   |           |                    |
|                                |  0.004040 |           0.088718 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.915063562999997 26.046863052 25.210505673]
Average time for minikube: 25.724144096

Times for Minikube (PR 7752): [24.952998613 25.175121262 26.104639518000003]
Average time for Minikube (PR 7752): 25.41091979766667

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7752) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.069005 |           0.073233 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002204 |           0.002266 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.055183 |           0.055701 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.322962 |           7.199515 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000158 |           0.000166 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.119233 |          16.621158 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.088613 |                    |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.063444 |           0.062585 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003341 |           0.001767 |
+----------------------------------------+-----------+--------------------+

tstromberg

Approved subject to last comment being resolved.

minikube-pr-bot · 2020-04-17T22:47:09Z

kvm2 Driver
Times for minikube: [62.920505484 66.365976327 63.353353958]
Average time for minikube: 64.21327858966667

Times for Minikube (PR 7752): [63.85507505100001 64.861424312 62.346334612]
Average time for Minikube (PR 7752): 63.687611325

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7752) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055881 |           0.057638 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019011 |           0.019017 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.008063 |           0.002651 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.684420 |          41.081571 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 20.824864 |          20.518917 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  2.542293 |                    |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.075314 |           0.070488 |
| configured to use "minikube"   |           |                    |
|                                |  0.003432 |           0.000819 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.90895325 25.277885318 25.01475983]
Average time for minikube: 25.733866132666666

Times for Minikube (PR 7752): [26.208657606000003 26.495569056 26.394490137]
Average time for Minikube (PR 7752): 26.366238933

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7752) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.073244 |           0.070689 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002677 |           0.002608 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.056578 |           0.056457 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.384949 |           7.456743 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000191 |           0.000145 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.123222 |          17.306791 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.024458 |                    |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.061383 |           0.063969 |
| configured to use "minikube"           |           |                    |
|                                        |  0.007164 |           0.002592 |
+----------------------------------------+-----------+--------------------+

codecov-io · 2020-04-17T22:55:53Z

Codecov Report

Merging #7752 into master will decrease coverage by 0.36%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7752      +/-   ##
==========================================
- Coverage   36.27%   35.90%   -0.37%     
==========================================
  Files         148      148              
  Lines        9203     9194       -9     
==========================================
- Hits         3338     3301      -37     
- Misses       5476     5497      +21     
- Partials      389      396       +7

Impacted Files	Coverage Δ
pkg/minikube/out/style.go	`91.66% <ø> (ø)`
pkg/addons/addons.go	`45.65% <100.00%> (-2.16%)`	⬇️
pkg/minikube/bootstrapper/images/images.go	`87.50% <0.00%> (-12.50%)`	⬇️
pkg/minikube/kubeconfig/kubeconfig.go	`61.06% <0.00%> (-7.63%)`	⬇️
pkg/minikube/service/service.go	`74.43% <0.00%> (-1.35%)`	⬇️
pkg/minikube/bootstrapper/bsutil/kubeadm.go	`83.09% <0.00%> (-0.47%)`	⬇️
cmd/minikube/cmd/config/configure.go	`1.61% <0.00%> (-0.07%)`	⬇️
cmd/minikube/cmd/tunnel.go	`5.12% <0.00%> (ø)`
cmd/minikube/cmd/service.go	`10.44% <0.00%> (ø)`
... and 2 more

minikube-pr-bot · 2020-04-17T23:26:19Z

kvm2 Driver
Times for minikube: [61.40298894200001 64.31589678600001 64.816286249]
Average time for minikube: 63.51172399233334

Times for Minikube (PR 7752): [67.903898066 65.612918249 62.48649695899999]
Average time for Minikube (PR 7752): 65.33443775799999

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7752) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.057077 |           0.055231 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.018391 |           0.018575 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003383 |           0.002834 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.600029 |          41.290379 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 20.793552 |          21.606396 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.951703 |                    |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.084551 |           0.070333 |
| configured to use "minikube"   |           |                    |
|                                |  0.003039 |           0.001414 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.667553157 25.418845987 24.476354578999995]
Average time for minikube: 25.18758457433333

Times for Minikube (PR 7752): [25.071264234999994 25.255369357000006 26.865733623]
Average time for Minikube (PR 7752): 25.730789071666667

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7752) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.071921 |           0.070832 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002700 |           0.002228 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.055640 |           0.059324 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.176860 |           7.420139 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000172 |           0.000167 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.889680 |          16.915083 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  0.924942 |                    |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.062062 |           0.059401 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003608 |           0.101468 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-18T00:17:11Z

kvm2 Driver
Times for minikube: [65.164716344 63.2265635 63.157086066]
Average time for minikube: 63.849455303333336

Times for Minikube (PR 7752): [63.85875819100001 64.853869062 64.454418177]
Average time for Minikube (PR 7752): 64.38901514333332

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7752) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.059550 |           0.054181 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019801 |           0.018982 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003756 |           0.002770 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.799788 |          40.893151 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.216060 |          21.194374 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.676819 |                    |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.070621 |           0.075325 |
| configured to use "minikube"   |           |                    |
|                                |  0.003060 |           0.007231 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.109152050000002 25.521386784 25.939433549999997]
Average time for minikube: 26.18999079466667

Times for Minikube (PR 7752): [26.359720358 25.390244548 26.347092649]
Average time for Minikube (PR 7752): 26.032352518333337

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7752) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.069291 |           0.068347 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002166 |           0.002109 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.058180 |           0.054514 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.280524 |           7.365713 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000133 |           0.000174 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.458684 |          17.699212 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.252559 |                    |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.063459 |           0.059830 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004994 |           0.005454 |
+----------------------------------------+-----------+--------------------+

medyagh · 2020-04-18T01:20:55Z

docker tests are both BusyBox

medyagh added 2 commits April 16, 2020 13:38

defer printing enabling addons

a023de6

defer print addon

0687e2a

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2020

k8s-ci-robot requested review from josedonizetti and RA489 April 17, 2020 18:22

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020

medyagh added 8 commits April 17, 2020 11:32

add WaitForNodeReady

44ff50f

rename appsrunning key to match others

991c97a

add node conditions and error types

76ca5e0

add styles for verifying

ffebe51

add node_ready for WaitForNode

ad00988

remove duplicate checking ShouldWait

710b289

add required verifying node conditions

786801d

add advise

100bc08

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2020

medyagh changed the title ~~wip: Node pressure redo~~ Check node pressure and add new --wait component Apr 17, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2020

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 17, 2020

lint

a18e27d

tstromberg suggested changes Apr 17, 2020

View reviewed changes

medyagh added 3 commits April 17, 2020 13:50

rename icon

4f04427

address review comments

4e74296

address review comments

cd99a47

make node pressure happen after all other waits

775a91c

medyagh changed the title ~~Check node pressure and add new --wait component~~ Check node pressure & new option "node_ready" for --wait Apr 17, 2020

add todo comment

70cbc67

tstromberg approved these changes Apr 17, 2020

View reviewed changes

run NodePressure after api server is up

5e36969

medyagh changed the title ~~Check node pressure & new option "node_ready" for --wait~~ Check node pressure & new option "node_ready" for --wait flag Apr 17, 2020

lint

21ad12f

medyagh merged commit fe4fdee into kubernetes:master Apr 18, 2020

medyagh deleted the node_pressure_redo branch May 2, 2020 22:32

prezha mentioned this pull request Mar 9, 2021

multinode cluster: fix waits and joins #10758

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Check node pressure & new option "node_ready" for --wait flag #7752

Check node pressure & new option "node_ready" for --wait flag #7752

medyagh commented Apr 17, 2020 •

edited

k8s-ci-robot commented Apr 17, 2020

medyagh commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

tstromberg left a comment

tstromberg Apr 17, 2020

medyagh Apr 17, 2020

medyagh commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

medyagh commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

tstromberg left a comment

minikube-pr-bot commented Apr 17, 2020

codecov-io commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 18, 2020

medyagh commented Apr 18, 2020

Check node pressure & new option "node_ready" for --wait flag #7752

Check node pressure & new option "node_ready" for --wait flag #7752

Conversation

medyagh commented Apr 17, 2020 • edited

Before this PR : (not veriifying disk pressure)

default new start

After this PR : default start

After this PR : --wait=all

after this pr --wait=false

k8s-ci-robot commented Apr 17, 2020

medyagh commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

tstromberg left a comment

Choose a reason for hiding this comment

tstromberg Apr 17, 2020

Choose a reason for hiding this comment

medyagh Apr 17, 2020

Choose a reason for hiding this comment

medyagh commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

medyagh commented Apr 17, 2020

minikube-pr-bot commented Apr 17, 2020

tstromberg left a comment

Choose a reason for hiding this comment

minikube-pr-bot commented Apr 17, 2020

codecov-io commented Apr 17, 2020

Codecov Report

minikube-pr-bot commented Apr 17, 2020

minikube-pr-bot commented Apr 18, 2020

medyagh commented Apr 18, 2020

medyagh commented Apr 17, 2020 •

edited