New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: minikube docker driver should surive Docker Daemon Stop/Start #9375
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rebase this and rerun integration tests before merge.
cef5f18
to
eb0b266
Compare
kvm2 Driver Times for Minikube (PR 9375): 74.1s 70.0s 73.2s Averages Time Per Log
docker Driver Times for Minikube (PR 9375): 42.3s 45.7s 40.9s Averages Time Per Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there seems to be a performance regression for start with the docker driver that we should fix before merge:
Closing this until performance regression can be investigated. |
Before this PR
After we stop Docker Desktop and then Start it agian, the minikube HOST status shows stopped
then
then start docker
After this PR
The Host shows running after we stop Docker Deskopt and then start it again
(the kublet and apiserver still need to fixed to show running too)
closes #9376