Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install system lib in build.sh #261

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
4 participants
@wangzhen127
Copy link
Member

commented Mar 13, 2019

Install journald system lib in build.sh

Part of #236.

@k8s-ci-robot k8s-ci-robot requested review from andyxning and Random-Liu Mar 13, 2019

@wangzhen127 wangzhen127 force-pushed the wangzhen127:fix-ci branch from ce85d35 to cb1815f Mar 13, 2019

@wangzhen127 wangzhen127 changed the title Install journald system lib in build.sh Install system lib in build.sh Mar 13, 2019

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

/assign @Random-Liu

@Random-Liu
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 13, 2019

@wangzhen127 wangzhen127 force-pushed the wangzhen127:fix-ci branch from cb1815f to db95aad Mar 13, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 13, 2019

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

/test pull-npd-e2e-node
/test pull-npd-e2e-kubernetes-gce-gci

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

/test pull-npd-build
/test pull-npd-test
/test pull-npd-e2e-kubernetes-gce-gci
/test pull-npd-e2e-kubernetes-gce-ubuntu
/test pull-npd-e2e-node

@krzyzacy

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

/test all

@krzyzacy

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

/woof

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 14, 2019

@krzyzacy: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

/test all

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

The build error shows:

cmd/node_problem_detector.go:29:2: cannot find package "k8s.io/node-problem-detector/cmd/options" in any of:
/home/prow/go/src/github.com/kubernetes/node-problem-detector/vendor/k8s.io/node-problem-detector/cmd/options (vendor tree)
/usr/local/go/src/k8s.io/node-problem-detector/cmd/options (from $GOROOT)
/home/prow/go/src/k8s.io/node-problem-detector/cmd/options (from $GOPATH)

It seems that node-problem-detector is put under "/home/prow/go/src/github.com/kubernetes/node-problem-detector/". But I think it should be "/home/prow/go/src/k8s.io/node-problem-detector/.

@krzyzacy, do I need to change anything on test-infra side?

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

Oh, I guess I missed path_alias?

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

/test all

@wangzhen127 wangzhen127 force-pushed the wangzhen127:fix-ci branch from db95aad to 7baf99b Mar 14, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Mar 14, 2019

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

/test all

@krzyzacy

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

Run: ('kubetest', '--dump=/logs/artifacts', '--gcp-service-account=/etc/service-account/service-account.json', '--up', '--down', '--test', '--cluster=bootstrap-e2e', '--gcp-network=bootstrap-e2e')
2019/03/14 18:10:26 process.go:96: Saved XML output to /logs/artifacts/junit_runner.xml.
2019/03/14 18:10:26 main.go:307: Something went wrong: called from invalid working directory: must run from kubernetes directory root: /home/prow/go/src/k8s.io/node-problem-detector

you need an --extract=foo flag

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

/test all

@krzyzacy

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

s/ci-latest/ci/latest

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

/test all

@wangzhen127 wangzhen127 force-pushed the wangzhen127:fix-ci branch from 7baf99b to 89ebd83 Mar 14, 2019

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/test all

@krzyzacy

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

/retest

@wangzhen127 wangzhen127 force-pushed the wangzhen127:fix-ci branch 2 times, most recently from d983113 to 479240a Mar 15, 2019

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/test all

1 similar comment
@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/test all

@krzyzacy

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

lol - I think you might want to quote the entire string?

@wangzhen127 wangzhen127 force-pushed the wangzhen127:fix-ci branch from 479240a to 9e3573e Mar 15, 2019

@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Mar 15, 2019

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/test all

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/retest

@wangzhen127 wangzhen127 force-pushed the wangzhen127:fix-ci branch 2 times, most recently from 5c83393 to 39d3b28 Mar 15, 2019

@wangzhen127

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

/test all

@wangzhen127 wangzhen127 force-pushed the wangzhen127:fix-ci branch from 39d3b28 to db5ab32 Mar 15, 2019

@Random-Liu

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Mar 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Random-Liu,wangzhen127]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 796c8d0 into kubernetes:master Mar 19, 2019

8 checks passed

cla/linuxfoundation wangzhen127 authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pull-npd-build Job succeeded.
Details
pull-npd-e2e-kubernetes-gce-gci Job succeeded.
Details
pull-npd-e2e-kubernetes-gce-ubuntu Job succeeded.
Details
pull-npd-e2e-node Job succeeded.
Details
pull-npd-test Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.