Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the testing example in README.md #385

Open
wants to merge 1 commit into
base: master
from

Conversation

@bhcleek
Copy link

bhcleek commented Nov 13, 2019

Fix the testing example in README.md so that it works as described to
show an event given that config/kernel-monitor-filelog.json expects a
string wrapped with square brackets to come right after kernel: .

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 13, 2019

Welcome @bhcleek!

It looks like this is your first PR to kubernetes/node-problem-detector 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/node-problem-detector has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 13, 2019

Hi @bhcleek. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 13, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bhcleek
To complete the pull request process, please assign dchen1107
You can assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from andyxning and xueweiz Nov 13, 2019
@bhcleek

This comment has been minimized.

Copy link
Author

bhcleek commented Nov 13, 2019

/assign @dchen1107

@andyxning

This comment has been minimized.

Copy link
Member

andyxning commented Nov 14, 2019

/ok-to-test

@andyxning

This comment has been minimized.

Copy link
Member

andyxning commented Nov 15, 2019

@bhcleek

You just add a timestamp 2019-11-13T19:28:16.288365+00:00 before kernel: , right? The config files are just examples, you need to adjust the rule patterns according to your /dev/kmsg log format since different Linux distributions have different formats. Even with the same Linux distribution, people can adjust the log format.

What we should do maybe add a statement like: The config files are just examples, you need to adjust the rule patterns according to your log records.

Fix the testing example in README.md so that it works as described to
show an event given that config/kernel-monitor-filelog.json expects a
string wrapped with square brackets to come right after `kernel: `.
@bhcleek bhcleek force-pushed the bhcleek:README/testing-example branch from 3b0a767 to dac9718 Nov 15, 2019
@bhcleek

This comment has been minimized.

Copy link
Author

bhcleek commented Nov 15, 2019

You're right as far as an accurate description of my changes go. Apparently I missed an important bit here: it was actually described in the commit message, but I failed to include the critical change. I've added amended the commit to correct that. The example now matches the message format specified in config/kernel-monitor-filelog.json

@xueweiz

This comment has been minimized.

Copy link
Contributor

xueweiz commented Dec 12, 2019

Sorry, the test failure is a flake, tracked in #403
/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.