New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new memberships - October 2 #130

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@cblecker
Member

cblecker commented Oct 2, 2018

fixes #120.
fixes #126.
fixes #127.

cblecker added some commits Oct 2, 2018

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 2, 2018

Member

/approve

Member

cblecker commented Oct 2, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 2, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 2, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta

This comment has been minimized.

Show comment
Hide comment
@fejta

fejta Oct 2, 2018

Contributor

/lgtm
/hold

Contributor

fejta commented Oct 2, 2018

/lgtm
/hold

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 2, 2018

Member

/hold cancel

Member

cblecker commented Oct 2, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit b42a88d into kubernetes:master Oct 2, 2018

4 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-org-test-all Job succeeded.
Details
pull-org-verify-all Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:memberships-oct2 branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment