New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add justaugustus and mrbobbytables as front line membership reviewers #140

Merged
merged 1 commit into from Oct 6, 2018

Conversation

Projects
None yet
6 participants
@cblecker
Member

cblecker commented Oct 4, 2018

@mrbobbytables

This comment has been minimized.

Show comment
Hide comment
@mrbobbytables

mrbobbytables Oct 5, 2018

Member

It looks like we need to added as members to several of the orgs before we can be added as reviewers. Would you like us to create an issue requesting membership and handle it separately from this PR?

Member

mrbobbytables commented Oct 5, 2018

It looks like we need to added as members to several of the orgs before we can be added as reviewers. Would you like us to create an issue requesting membership and handle it separately from this PR?

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 5, 2018

Member

@justaugustus @mrbobbytables As you're both members of @kubernetes, you're eligible automatically to be in the other orgs. I've added you both to the missing orgs.

Member

cblecker commented Oct 5, 2018

@justaugustus @mrbobbytables As you're both members of @kubernetes, you're eligible automatically to be in the other orgs. I've added you both to the missing orgs.

@justaugustus

This comment has been minimized.

Show comment
Hide comment
@justaugustus

justaugustus Oct 6, 2018

Member

Cool beans!
/lgtm

For approval:
/assign @calebamiles @spiffxp

Member

justaugustus commented Oct 6, 2018

Cool beans!
/lgtm

For approval:
/assign @calebamiles @spiffxp

@cblecker

This comment has been minimized.

Show comment
Hide comment
@cblecker

cblecker Oct 6, 2018

Member

/approve

Member

cblecker commented Oct 6, 2018

/approve

@k8s-ci-robot

This comment has been minimized.

Show comment
Hide comment
@k8s-ci-robot

k8s-ci-robot Oct 6, 2018

Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

k8s-ci-robot commented Oct 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4dddecb into kubernetes:master Oct 6, 2018

4 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-org-test-all Job succeeded.
Details
pull-org-verify-all Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:nmc branch Oct 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment