Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI signal github team #1404

Merged
merged 1 commit into from Nov 14, 2019
Merged

Add CI signal github team #1404

merged 1 commit into from Nov 14, 2019

Conversation

@alenkacz
Copy link
Contributor

alenkacz commented Nov 8, 2019

This will make it easier to contact the CI signal team within the big amount of issues we're supposed to be looking after.

@k8s-ci-robot k8s-ci-robot requested review from justaugustus and tpepper Nov 8, 2019
@alenkacz alenkacz force-pushed the alenkacz:patch-1 branch 2 times, most recently from a5cfc45 to 02246a8 Nov 8, 2019
Copy link
Contributor

hasheddan left a comment

Thanks @alenkacz!

Copy link
Member

cblecker left a comment

Need to set the privacy of the team to “closed” so it doesn’t default to “secret”. Have a look at another team’s syntax for an example.

@alenkacz alenkacz force-pushed the alenkacz:patch-1 branch from 02246a8 to 93a5547 Nov 8, 2019
@alenkacz

This comment has been minimized.

Copy link
Contributor Author

alenkacz commented Nov 8, 2019

@cblecker oh thanks, done :)

Copy link
Member

justaugustus left a comment

@alenkacz -- Great idea! A few nits here around the name and member descriptions.

Also, can you open a PR in k/sig-release to document this new GitHub team?
I'm going to put a hold on this until then.
/hold

@@ -1,4 +1,13 @@
teams:
release-ci-signal:
description: Members of the CI signal team for the current iteration.

This comment has been minimized.

Copy link
@justaugustus

justaugustus Nov 8, 2019

Member
Suggested change
description: Members of the CI signal team for the current iteration.
description: Members of the CI Signal team for the current release cycle.
release-ci-signal:
description: Members of the CI signal team for the current iteration.
members:
- alenkacz

This comment has been minimized.

Copy link
@justaugustus

justaugustus Nov 8, 2019

Member
Suggested change
- alenkacz
- alenkacz # 1.17 CI Signal Lead
description: Members of the CI signal team for the current iteration.
members:
- alenkacz
- droslean

This comment has been minimized.

Copy link
@justaugustus

justaugustus Nov 8, 2019

Member
Suggested change
- droslean
- droslean # 1.17 CI Signal shadow
members:
- alenkacz
- droslean
- epk

This comment has been minimized.

Copy link
@justaugustus

justaugustus Nov 8, 2019

Member
Suggested change
- epk
- epk # 1.17 CI Signal shadow
- alenkacz
- droslean
- epk
- hasheddan

This comment has been minimized.

Copy link
@justaugustus

justaugustus Nov 8, 2019

Member
Suggested change
- hasheddan
- hasheddan # 1.17 CI Signal shadow
- droslean
- epk
- hasheddan
- verolop

This comment has been minimized.

Copy link
@justaugustus

justaugustus Nov 8, 2019

Member
Suggested change
- verolop
- verolop # 1.17 CI Signal shadow
@@ -1,4 +1,13 @@
teams:
release-ci-signal:

This comment has been minimized.

Copy link
@justaugustus

justaugustus Nov 8, 2019

Member
Suggested change
release-ci-signal:
ci-signal:
@cblecker cblecker dismissed their stale review Nov 8, 2019

Resolved

@alenkacz alenkacz force-pushed the alenkacz:patch-1 branch from 93a5547 to 93753c8 Nov 9, 2019
@alenkacz

This comment has been minimized.

Copy link
Contributor Author

alenkacz commented Nov 9, 2019

@justaugustus thanks for the suggestions - fixed.

What would be a good place for the documentation. CI signal handbook would work for you? Is there a better place?

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Nov 10, 2019

@alenkacz -- Yep, the CI Signal handbook should be fine. I basically just want a note somewhere so that someone ensures the team stays up to date. :)

One more thing; can you alpha-sort the list with respect to the others?
This new team should be listed after build-admins.

@alenkacz alenkacz force-pushed the alenkacz:patch-1 branch from 93753c8 to 17f7fbd Nov 14, 2019
@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Nov 14, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alenkacz, hasheddan, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alenkacz

This comment has been minimized.

Copy link
Contributor Author

alenkacz commented Nov 14, 2019

@justaugustus I am just working on the PR with docs :) will land in couple of minutes

@alenkacz

This comment has been minimized.

Copy link
Contributor Author

alenkacz commented Nov 14, 2019

@justaugustus kubernetes/sig-release#858 this is the docs update. Can we remove the hold now?

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Nov 14, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit bc13827 into kubernetes:master Nov 14, 2019
3 of 4 checks passed
3 of 4 checks passed
tide Not mergeable. Should not have do-not-merge/hold label.
Details
cla/linuxfoundation alenkacz authorized
Details
pull-org-test-all Job succeeded.
Details
pull-org-verify-all Job succeeded.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.