New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable team management for peribolos #337

Merged
merged 3 commits into from Jan 11, 2019

Conversation

@cblecker
Copy link
Member

cblecker commented Jan 8, 2019

馃檴!

This might actually work.
fixes #336

/assign @fejta @spiffxp
/hold

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Jan 9, 2019

@cblecker 馃帀 馃巿

Two questions:

  • Can we move the teams to a teams.yaml and merge the configs to avoid bloating org.yaml, like we do for contribex? Or do we intend to move to a teams.yaml for each SIG later?

  • Out of curiosity, how do --dump, --fix-teams and --fix-team-members come to know that sig-contribex teams should be dumped in its teams.yaml file and not append those in org.yaml? 馃

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 9, 2019

@nikhita Thanks for feedback!

Can we move the teams to a teams.yaml and merge the configs to avoid bloating org.yaml, like we do for contribex?

Yes, we can.. it just requires manually trimming out the groups into a new folder, like contribex and apimachinery. I haven't done that yet, because it's a manual process, and I'm currently trying to keep the dump sync'd with what's in GitHub.

Out of curiosity, how do --dump, --fix-teams and --fix-team-members come to know that sig-contribex teams should be dumped in its teams.yaml file and not append those in org.yaml?

Manually :) I dumped out the list of teams, and then extracted out contribex and apimachinery as examples. I want to get peribolos as the source of truth first, and then we can do it for all the sigs to delegate approve rights.

@fejta

This comment has been minimized.

Copy link
Contributor

fejta commented Jan 9, 2019

Manually :) I dumped out the list of teams, and then extracted out contribex and apimachinery as examples.

However we organize the files https://github.com/kubernetes/org/tree/master/cmd/merge will then stitch them back together into one config.

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Jan 9, 2019

Manual sounds like a lot of work though 馃槢 ....if teams have consistent naming, maybe we could automate it? But I think we should discuss this later on an issue somewhere and not on this PR. Thanks for getting this ready, again! 馃挴 :shipit:

@fejta
Copy link
Contributor

fejta left a comment

/lgtm
Any chance we want to leave out the third commit that enables --fix-teams and put that in a separate PR?

maintainers:
- fejta
- k8s-ci-robot
privacy: secret

This comment has been minimized.

@fejta

fejta Jan 9, 2019

Contributor

LOL

Bots:
description: Hmm, not working like I hoped...
maintainers:
- fejta

This comment has been minimized.

@fejta

fejta Jan 9, 2019

Contributor

why am I a bot?! 馃榿

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 9, 2019

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 9, 2019

@fejta The reason I'm just turning it all on now is we would need a last "sync" from GitHub before we turn it on anyways. I figure I'll do that Friday morning right before merge.

@cblecker cblecker force-pushed the cblecker:teams-yay branch from 5de35f8 to 85e8fed Jan 11, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jan 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cblecker added some commits Jan 11, 2019

@cblecker cblecker force-pushed the cblecker:teams-yay branch from 85e8fed to fd5f8c4 Jan 11, 2019

@fejta

This comment has been minimized.

Copy link
Contributor

fejta commented Jan 11, 2019

/lgtm
/hold
exciting! I guess Friday afternoon is the natural time to make this switch?

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 11, 2019

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 11, 2019

/hold cancel
Let's do this! 馃殌

@k8s-ci-robot k8s-ci-robot merged commit 8f5d5d9 into kubernetes:master Jan 11, 2019

4 checks passed

cla/linuxfoundation cblecker authorized
Details
pull-org-test-all Job succeeded.
Details
pull-org-verify-all Job succeeded.
Details
tide In merge pool.
Details

@cblecker cblecker deleted the cblecker:teams-yay branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment