New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SIG Release teams #351

Merged
merged 1 commit into from Jan 15, 2019

Conversation

@justaugustus
Copy link
Member

justaugustus commented Jan 12, 2019

  • Add dims and liggitt as SIG Release-designated milestone maintainers
  • Prune kubernetes-release-managers team
  • Add 1.14 RT to sig-release team
  • Prune sig-release-admins

Closes: kubernetes/sig-release#353

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @calebamiles @tpepper @cblecker

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 12, 2019

/hold

@justaugustus Until we get the automation back online, I’ll have to process these manually.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 12, 2019

@cblecker -- These can definitely wait until peribolos is on its' feet. Thanks for being so attentive! :)

- k8s-release-robot
privacy: closed
sig-release:
description: SIG Release Members
maintainers:
- spiffxp

This comment has been minimized.

@cblecker

cblecker Jan 13, 2019

Member

You may have to revert this. Because @spiffxp is an org owner, he's implicitly a maintainer of every team he's a member of. I think this will throw an error.

This comment has been minimized.

@cblecker

cblecker Jan 13, 2019

Member

Let me test this first..

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 14, 2019

/test all

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 14, 2019

Tests have been improved!

--- FAIL: TestAllOrgs (0.06s)
    config_test.go:237: The following members of team sig-release are not org members: claurence, nwoods3
@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 14, 2019

@claurence @nwoods3 -- Could you work on becoming Kubernetes org members?

@cblecker -- I'm going to remove them in the meantime.

@nikhita -- h/t for the improved tests!

@justaugustus justaugustus force-pushed the justaugustus:sig-release branch from 82c524e to 23cb93f Jan 14, 2019

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 14, 2019

Yeah, org owners need to be left as maintainers of a team.

{"client":"github","component":"peribolos","level":"info","msg":"UpdateTeamMembership(2460384, cblecker, false)","time":"2019-01-14T14:04:46-08:00"}
{"component":"peribolos","level":"info","msg":"Set cblecker as a member of 2460384","time":"2019-01-14T14:04:46-08:00"}
{"client":"github","component":"peribolos","level":"info","msg":"UpdateTeamMembership(2460384, idvoretskyi, false)","time":"2019-01-14T14:04:46-08:00"}
{"component":"peribolos","level":"info","msg":"Set idvoretskyi as a member of 2460384","time":"2019-01-14T14:04:46-08:00"}
{"client":"github","component":"peribolos","level":"info","msg":"UpdateTeamMembership(2460384, fejta, false)","time":"2019-01-14T14:04:46-08:00"}
{"component":"peribolos","level":"info","msg":"Set fejta as a member of 2460384","time":"2019-01-14T14:04:46-08:00"}

Otherwise we will try to change their status every time peribolos runs, and fail. Let me write a test for this.

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 14, 2019

@justaugustus request submitted today to join: #354 (comment)

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Jan 14, 2019

@justaugustus ref: #355 for @nwoods3

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 14, 2019

@spiffxp / @claurence / @nwoods3 -- thanks! Will process the membership requests shortly. :)

@justaugustus justaugustus force-pushed the justaugustus:sig-release branch from 23cb93f to 0a05b11 Jan 14, 2019

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 14, 2019

@spiffxp / @claurence / @nwoods3 -- thanks! Will process the membership requests shortly. :)

PR to add Claire and Natasha here: #358

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 14, 2019

Going to add 1.14 RT leads to milestone maintainers. Stand by.

@justaugustus justaugustus force-pushed the justaugustus:sig-release branch from 0a05b11 to 43e24bb Jan 14, 2019

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 14, 2019

@cblecker -- updated and ready for approval (assuming the tests don't fail), so I'm pulling the hold. Feel to put it back, if need be.
/hold cancel

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 15, 2019

/test all

Update SIG Release teams
- Add dims and liggitt as SIG Release-designated milestone maintainers
- Prune `kubernetes-release-managers` team
- Add 1.14 RT to `sig-release` team
- Prune `sig-release-admins`

Signed-off-by: Stephen Augustus <saugustus@vmware.com>

@justaugustus justaugustus force-pushed the justaugustus:sig-release branch from 43e24bb to 32ebca0 Jan 15, 2019

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 15, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jan 15, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 64d702c into kubernetes:master Jan 15, 2019

4 checks passed

cla/linuxfoundation justaugustus authorized
Details
pull-org-test-all Job succeeded.
Details
pull-org-verify-all Job succeeded.
Details
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment