Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XiaoningDing from kubernetes #793

Merged
merged 1 commit into from May 6, 2019

Conversation

Projects
None yet
4 participants
@cblecker
Copy link
Member

commented May 6, 2019

This person removed themselves from the GitHub org and we immediately re-invited them. This removes that invitation.

@justaugustus

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Don't they still need to be listed though?

@nikhita

nikhita approved these changes May 6, 2019

Copy link
Member

left a comment

/lgtm
/hold

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Don't they still need to be listed though?

If we remove them from the list, this will no longer try to invite them to the org. Right now, even if they want to leave the org, being on the list means they'll keep getting an invitation.

@justaugustus

This comment has been minimized.

Copy link
Member

commented May 6, 2019

Ahhh, I took the description to mean they had accidentally left the org. Don't mind me! 😅

@nikhita

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@justaugustus np :)

/hold cancel
We can always add them back if needed.

@k8s-ci-robot k8s-ci-robot merged commit a50c8c7 into kubernetes:master May 6, 2019

3 of 4 checks passed

tide Not mergeable. Should not have do-not-merge/hold label.
Details
cla/linuxfoundation cblecker authorized
Details
pull-org-test-all Job succeeded.
Details
pull-org-verify-all Job succeeded.
Details

@cblecker cblecker deleted the cblecker:remove-xiaoningding branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.