probers: log to file #981
Merged
probers: log to file #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
mm4tt
reviewed
Jan 14, 2020
clusterloader2/pkg/measurement/common/probes/manifests/dnsLookup/dns-prober-deployment.yaml
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
size/S
oxddr
force-pushed
the
logotofile
branch
2 times, most recently
from
6e20c01
to
6f5d72b
Compare
|
/lgtm This LGTM, but let's wait for the kubernetes/test-infra#15895 to get first so we can verify that everything works in the presubmit /hold |
k8s-ci-robot
added
lgtm
k8s-ci-robot
removed
the
lgtm
|
PTAL |
|
/lgtm /hold |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, oxddr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/test pull-perf-tests-clusterloader2 |
|
/test pull-perf-tests-clusterloader2-kubemark |
|
Logs has been successfully collected in the presubmit's test (e.g.
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/perf-tests/981/pull-perf-tests-clusterloader2/1230808617817477120/artifacts/e2e-981-62db2-minion-group-m4pp/cl2-dns-lookup.log
)
|
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref kubernetes/kubernetes#87143
/assign @mm4tt