Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNI cosmetics #113

Closed
errordeveloper opened this issue Sep 22, 2016 · 11 comments
Closed

CNI cosmetics #113

errordeveloper opened this issue Sep 22, 2016 · 11 comments

Comments

@errordeveloper
Copy link
Member

@errordeveloper errordeveloper commented Sep 22, 2016

Paths

We've had to put CNI bits in /opt, as there was no way to tell kubelet to look in other places. As of kubernetes/kubernetes#32151 (already in 1.4), we can pass --cni-bin-dir= as well as --cni-conf-dir= to kubelet. I makes sense to put the plugins into /usr/lib/cni or /usr/lib/kubelet/cni/bin or /usr/libexec/cni - anything other then /opt is good. The reason for this is that traditionally /opt is used for installing ad-hoc pieces, not for things installed by the package manager. We could also move /etc/cni to /etc/kubernets/cni, so we have everything in one directory.

Package name

I seems like kuberentes-cni would be something user has to lookup, calling it kubernetes-cni-basic-network-plugins (or just kubernetes-basic-network-plugins) would make it more obvious. Word "basic" (or "vanilla" or "generic" or something similar) is also good, so we don't give user the impression that they'll have all the plugins.

@luxas
Copy link
Member

@luxas luxas commented Sep 30, 2016

cc @kubernetes/sig-cluster-lifecycle

I think /etc/cni/bin or just /opt/cni/bin (as it is now) are my preferred locations, as they have to work on CoreOS as well (where /usr/ is ro)

About naming, kubernetes-basic-cni sgtm, if we think we have to change it

@mattymo
Copy link
Contributor

@mattymo mattymo commented Oct 12, 2016

I think cni should definitely be in the package name, with the (searchable) package description being Kubernetes container network interface standard plugins. Deciding over calling the plugins basic, standard, or so on is not too important to me.

Secondly, it would be nice to make a search tree (overrideable by --cni-bin-dir) to meet these requirements. No decent RPM/DEB packager wants to use /opt these days. /usr/lib/$PKGNAME/cni/ or /usr/libexec/$PKGNAME are both okay paths for me. /etc/cni/bin I would -1 because there should be nothing except configuration files in /etc.

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Dec 18, 2017

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@fejta-bot
Copy link

@fejta-bot fejta-bot commented Jan 17, 2018

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@errordeveloper
Copy link
Member Author

@errordeveloper errordeveloper commented Jan 22, 2018

/remove-lifecycle rotten
/lifecycle frozen

@dims
Copy link
Member

@dims dims commented Oct 23, 2018

@errordeveloper @mattymo is this still relevant issue? can we please close the issue otherwise?

@errordeveloper
Copy link
Member Author

@errordeveloper errordeveloper commented Oct 24, 2018

@justaugustus
Copy link
Member

@justaugustus justaugustus commented May 1, 2019

/help
/milestone v1.15
/priority important-soon
/area release-eng
related: kubernetes/sig-release#245

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented May 1, 2019

@justaugustus:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/milestone v1.15
/priority important-soon
/area release-eng
related: kubernetes/sig-release#245

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member

@justaugustus justaugustus commented Jan 29, 2020

Closing as I agree with @BenTheElder's assessment in #862.

We're planning on moving the CNI plugins into the kubelet package.
See here to track the deprecation of kubernetes-cni deb/rpm packages: #885

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jan 29, 2020

@justaugustus: Closing this issue.

In response to this:

Closing as I agree with @BenTheElder's assessment in #862.

We're planning on moving the CNI plugins into the kubelet package.
See here to track the deprecation of kubernetes-cni deb/rpm packages: #885

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Release Engineering automation moved this from To do to Done (1.18) Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants