Skip to content

Add release message to krel stage #1708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2020
Merged

Add release message to krel stage #1708

merged 1 commit into from
Nov 10, 2020

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Nov 10, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

This adds the message for releasing the staged artifacts to krel stage.

Which issue(s) this PR fixes:

Refers to #1673

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added `krel gcbmgr --release …` message if `krel stage` finished staging the artifacts.

@saschagrunert
Add release message to krel stage
fcb3fa7 
This adds the message for releasing the staged artifacts to `krel
stage`.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 10, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 10, 2020
@cpanato cpanato added this to the v1.20 milestone Nov 10, 2020
cpanato
cpanato approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d820df1 into kubernetes:master Nov 10, 2020
@saschagrunert saschagrunert deleted the release-message branch November 10, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato cpanato approved these changes

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

Assignees

@cpanato cpanato

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.20

Development

Successfully merging this pull request may close these issues.

3 participants

@saschagrunert @k8s-ci-robot @cpanato