Skip to content

Add release notes JSON to artifacts #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

Add release notes JSON to artifacts #1805

merged 1 commit into from
Nov 30, 2020

Conversation

@saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Nov 30, 2020

What type of PR is this?

/kind feature

What this PR does / why we need it:

This change allows us to create a release notes JSON as archived release artifact. Target is to re-use the new artifact directly from the release notes website.

Which issue(s) this PR fixes:

Refers to #1087

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added release notes JSON as krel stage/release artifact

@saschagrunert
Add release notes JSON to artifacts
8ee1ec4 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2020
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 30, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 30, 2020 •
edited
Loading

Now the JSON blob can be found in the release archive:
https://console.cloud.google.com/storage/browser/_details/kubernetes-release-gcb/archive/anago-v1.20.0-beta.3/release-notes.json

Or via the public URL:
https://storage.googleapis.com/kubernetes-release-gcb/archive/anago-v1.20.0-beta.3/release-notes.json

@saschagrunert saschagrunert changed the title WIP: Add release notes JSON to artifacts Add release notes JSON to artifacts Nov 30, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 30, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 30, 2020

/hold

Let's wait for v1.20.0-rc.0 before merging this.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2020
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 30, 2020

/hold cancel

Might be better to merge sooner rather than later.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2020
xmudrii
xmudrii approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 30, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e0962dd into kubernetes:master Nov 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 30, 2020
@saschagrunert saschagrunert deleted the json branch November 30, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xmudrii xmudrii xmudrii approved these changes

@hasheddan hasheddan Awaiting requested review from hasheddan

Assignees

@xmudrii xmudrii

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.20

Development

Successfully merging this pull request may close these issues.

3 participants

@saschagrunert @k8s-ci-robot @xmudrii